Add support for all available options for CreateCollectionChange #78
Conversation
Made AbstractCollectionStatement.toJs abstract and fixed CountCollectionByNameStatement implementation of it.
| @@ -50,4 +50,9 @@ public long queryForLong(final MongoConnection connection) { | |||
| .filter(s -> s.equals(getCollectionName())) | |||
| .count(); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
A correct implementation of toJs for the count method.
Is needed since I made the baseclass method abstract
There was a problem hiding this comment.
This is actually counting collections not documents
There was a problem hiding this comment.
will fix in a subsequent commit
There was a problem hiding this comment.
Sorry for the misunderstanding. I see now how this is used and is different from CountDocumentsInCollectionStatement.
This could only ever return zero or one, so could potentially be made clearer by refactoring it to implement a new interface such as NoSqlQueryForBooleanStatement:
public boolean exists(MongoConnection connection);
Thoughts?
There was a problem hiding this comment.
Yes, could worth, it's just I tend to stay similar with Executor methods from liquibase core, otherwise can get into unsupported features when new Liquibase release.
| commandOptions.putAll(options); | ||
| } | ||
| return commandOptions.toBsonDocument(Document.class, getDefaultCodecRegistry()); | ||
| } |
There was a problem hiding this comment.
create:<collectionName> needs to be the first entry in the Document, followed by any options if present.
…ents, changed to AbstractRunCommandStatement.
| @@ -50,4 +50,9 @@ public long queryForLong(final MongoConnection connection) { | |||
| .filter(s -> s.equals(getCollectionName())) | |||
| .count(); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This is actually counting collections not documents
| @@ -50,4 +50,9 @@ public long queryForLong(final MongoConnection connection) { | |||
| .filter(s -> s.equals(getCollectionName())) | |||
| .count(); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
will fix in a subsequent commit
| import org.bson.codecs.UuidCodec; | ||
| import org.bson.codecs.UuidCodecProvider; | ||
| import org.bson.codecs.ValueCodecProvider; | ||
| import org.bson.codecs.*; |
There was a problem hiding this comment.
Expand from a wildchar. Will fix in sub commit
|
|
||
| import static java.util.Optional.ofNullable; | ||
| import static com.mongodb.MongoClientSettings.getDefaultCodecRegistry; |
There was a problem hiding this comment.
will move into BsonUtils in a subsequent commit
Changed
CreateCollectionStatementto execute as a mongoDBrunCommandso that it supports all available server options.Made
AbstractCollectionStatement.toJs()method abstract and fixed theCountCollectionByNameStatementimplementation of it.┆Issue is synchronized with this Jira Bug by Unito