Don't force a build.edn file #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @liquidz Did you by any chance have time to look at this? Thanks and best regards. |
|
@ivarref Ah sorry. I've overlooked this PR. |
Co-authored-by: Iizuka Masashi <[email protected]>
liquidz
requested changes
Apr 10, 2024
There was a problem hiding this comment.
@ivarref Sorry, just one last point.
Could you also remove the following alpha?
|
Fixed test 👍 |
liquidz
approved these changes
Apr 11, 2024
|
@ivarref Just released v0.11.257 :) |
|
Thanks a lot @liquidz ❤️ 🧡 💛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't force a build.edn file.
The user can store all the config needed in deps.edn if she/he likes.
I also bumped deps-deploy. That also required removing the .alpha for tools.deps usage.
What do you think?
Thanks for a great and user friendly project.
Best regards