Skip to content

Commit

Permalink
fix platform compat tests
Browse files Browse the repository at this point in the history
Signed-off-by: Janek Nouvertné <[email protected]>
  • Loading branch information
provinzkraut committed Sep 17, 2023
1 parent 359fa32 commit 771e671
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:

test:
strategy:
fail-fast: true
fail-fast: false
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11"]
pydantic-version: ["1", "2"]
Expand All @@ -44,7 +44,6 @@ jobs:
python-version: ${{ matrix.python-version }}

test-platform-compat:
if: github.event_name == 'push'
strategy:
fail-fast: false
matrix:
Expand Down
2 changes: 1 addition & 1 deletion tests/docker_service_fixtures.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def down(self) -> None:

@pytest.fixture(scope="session")
def docker_services(worker_id: str) -> Generator[DockerServiceRegistry, None, None]:
if os.getenv("GITHUB_ACTIONS") == "true" and sys.platform == "win32":
if os.getenv("GITHUB_ACTIONS") == "true" and sys.platform != "linux":
pytest.skip("Docker not available on this platform")

registry = DockerServiceRegistry(worker_id)
Expand Down
4 changes: 2 additions & 2 deletions tests/examples/test_contrib/test_piccolo_orm.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
pytestmark = [
pytest.mark.xdist_group("piccolo"),
pytest.mark.skipif(
sys.platform == "win32",
reason="piccolo ORM itself is not tested against windows",
sys.platform != "linux",
reason="piccolo ORM itself is not tested against windows and macOS",
),
]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ async def app(monkeypatch: MonkeyPatch, request: FixtureRequest) -> Litestar:
return app_module.app


@pytest.mark.skipif(sys.platform == "win32", reason="fails on Windows, in CI only")
@pytest.mark.skipif(sys.platform != "linux", reason="Unknown - fails on Windows and macOS, in CI only")
def test_no_plugins_full_app(app: Litestar) -> None:
todo = {"title": "Start writing todo list", "done": True}
todo_list = [todo]
Expand Down

0 comments on commit 771e671

Please sign in to comment.