fix(tests): fix platform compat tests (#2310)

* fix platform compat tests * fix mako template test for windows --------- Signed-off-by: Janek Nouvertné <[email protected]>
litestar-org · Sep 18, 2023 · f73da61 · f73da61
1 parent 359fa32
commit f73da61
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/tests/docker_service_fixtures.py b/tests/docker_service_fixtures.py
@@ -102,7 +102,7 @@ def down(self) -> None:
 
 @pytest.fixture(scope="session")
 def docker_services(worker_id: str) -> Generator[DockerServiceRegistry, None, None]:
- if os.getenv("GITHUB_ACTIONS") == "true" and sys.platform == "win32":
+ if os.getenv("GITHUB_ACTIONS") == "true" and sys.platform != "linux":
  pytest.skip("Docker not available on this platform")
 
  registry = DockerServiceRegistry(worker_id)

diff --git a/tests/examples/test_contrib/test_piccolo_orm.py b/tests/examples/test_contrib/test_piccolo_orm.py
@@ -16,8 +16,8 @@
 pytestmark = [
  pytest.mark.xdist_group("piccolo"),
  pytest.mark.skipif(
- sys.platform == "win32",
- reason="piccolo ORM itself is not tested against windows",
+ sys.platform != "linux",
+ reason="piccolo ORM itself is not tested against windows and macOS",
  ),
 ]
 

diff --git a/tests/examples/test_contrib/test_sqlalchemy/plugins/test_tutorial_example_apps.py b/tests/examples/test_contrib/test_sqlalchemy/plugins/test_tutorial_example_apps.py
@@ -45,7 +45,7 @@ async def app(monkeypatch: MonkeyPatch, request: FixtureRequest) -> Litestar:
  return app_module.app
 
 
-@pytest.mark.skipif(sys.platform == "win32", reason="fails on Windows, in CI only")
+@pytest.mark.skipif(sys.platform != "linux", reason="Unknown - fails on Windows and macOS, in CI only")
 def test_no_plugins_full_app(app: Litestar) -> None:
  todo = {"title": "Start writing todo list", "done": True}
  todo_list = [todo]

diff --git a/tests/examples/test_templating/test_returning_templates.py b/tests/examples/test_templating/test_returning_templates.py
@@ -14,7 +14,7 @@ def test_returning_templates_jinja():
 def test_returning_templates_mako():
  with TestClient(mako_app) as client:
  response = client.get("/", params={"name": "Mako"})
- assert response.text == "Hello <strong>Mako</strong>\n"
+ assert response.text.strip() == "Hello <strong>Mako</strong>"
 
 
 def test_returning_templates_minijinja():

diff --git a/tests/examples/test_templating/test_template_functions.py b/tests/examples/test_templating/test_template_functions.py
@@ -14,7 +14,7 @@ def test_template_functions_jinja():
 def test_template_functions_mako():
  with TestClient(mako_app) as client:
  response = client.get("/")
- assert response.text == "<strong>check_context_key: </strong>nope\n"
+ assert response.text.strip() == "<strong>check_context_key: </strong>nope"
 
 
 def test_template_functions_minijinja():