fix(sqlalchemy-repo): #2221 - Filters not available in exists()
#2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 26, 2023 11:43
also changed the functions in the repository abc. and the generic_mock_repository.py. that one used get_one_or_none that doesn't seem right
…st_sqlalchemy.py. hope this is correct.
nielsvanhooy
changed the title
nielsvanhooy
changed the title
provinzkraut
approved these changes
Aug 26, 2023
provinzkraut
changed the title
exists()
|
@all-contributors add @nielsvanhooy for bugs, tests, and code |
|
I've put up a pull request to add @nielsvanhooy! 🎉 |
cofin
approved these changes
Aug 26, 2023
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed exists() method for sqlalchemy sync and async.
also changed the functions in the repository abc. and the generic_mock_repository.py. that one used get_one_or_none that doesn't seem right
also added 2 tests for usage with the filter (let me know if this is correct).
Pull Request Checklist
Description
FIX: Calling exists() with filters doesn't work SQLAlchemy contrib
Close Issue(s)
Fixes #2221