-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add minjinja #2250
feat: add minjinja #2250
Conversation
…e can pass the builtin_functions tests, need to dig
So, why would anyone want to use this instead of jinja? |
from https:/mitsuhiko/minijinja/tree/main/minijinja-py
some people may be interested to test the speed also, I dont know. but in any case it should be seen as a jinja replacement, the python bindings page explains quite well the main differences. |
170cd6c
to
34b9f62
Compare
I honestly dont understand the error in the CI here |
Please update the documentation and readme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good, but needs update to docs and readme before proceeding.
fix: add tests for docs/examples/templating
fix: seems mako prints a \n at end of templates if the html conatins one
fix: typos in tabs names
ok I have a small annoyance here in new tests:
it's because the file I'm caught in a chiken and egg issue, if I remove the \n from the template file hello.html.mako then pyright will fail in the CI but new tests pass, should the test for mako be changed to reflect that slight discrepency between jinja and mako ? |
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2250 |
Description
Close Issue(s)