Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add pydantic types to sqlalchemy registry only if pydantic is installed #2252

Merged
merged 1 commit into from
Aug 28, 2023
Merged

fix: add pydantic types to sqlalchemy registry only if pydantic is installed #2252

merged 1 commit into from
Aug 28, 2023

Conversation

guacs
Copy link
Member

@guacs guacs commented Aug 28, 2023

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR

Description

  • This PR allows importing from litestar.contrib.sqlalchemy.base even if pydantic is not installed.

@guacs guacs requested review from a team as code owners August 28, 2023 16:28
@github-actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2252

@provinzkraut provinzkraut merged commit 259ab3f into litestar-org:main Aug 28, 2023
16 checks passed
@guacs guacs deleted the sqlalchemy-base-type-annotation-map branch August 28, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provinzkraut provinzkraut provinzkraut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guacs @provinzkraut