Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update MessagPack media type #3732

Merged
merged 1 commit into from
Sep 14, 2024
Merged

feat: Update MessagPack media type #3732

merged 1 commit into from
Sep 14, 2024

Conversation

provinzkraut
Copy link
Member

Update the MessagePack media type to the official application/vnd.msgpack.

Fixes #3727.

@provinzkraut provinzkraut requested review from a team as code owners September 14, 2024 08:13
@github-actions github-actions bot added area/docs This PR involves changes to the documentation area/enums This PR involves changes to the enums size: small type/feat pr/internal labels Sep 14, 2024
@provinzkraut provinzkraut enabled auto-merge (squash) September 14, 2024 08:29
@provinzkraut provinzkraut linked an issue Sep 14, 2024 that may be closed by this pull request
Enhancement: Switch to official msgpack media type #3727
Closed
@codecov Codecov
Copy link

codecov bot commented Sep 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.26%. Comparing base (2292b5d) to head (973be54).
Report is 1 commits behind head on v3.0.

Additional details and impacted files 
@@           Coverage Diff           @@
##             v3.0    #3732   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files         325      325           
  Lines       14746    14746           
  Branches     2335     2335           
=======================================
  Hits        14490    14490           
  Misses        119      119           
  Partials      137      137

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@provinzkraut provinzkraut merged commit f9b3867 into v3.0 Sep 14, 2024
23 of 24 checks passed
@provinzkraut provinzkraut deleted the change-msgpack-media-type branch September 14, 2024 09:55
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7 New Major Issues (required ≤ 2)
8 New Code Smells (required ≤ 3)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@provinzkraut provinzkraut mentioned this pull request Sep 14, 2024
Closed
provinzkraut added a commit that referenced this pull request Sep 15, 2024
@provinzkraut
feat: Update MessagPack media type (#3732)
34a9f04
provinzkraut added a commit that referenced this pull request Sep 15, 2024
@provinzkraut
feat: Update MessagPack media type (#3732)
1e37c0c
provinzkraut added a commit that referenced this pull request Sep 21, 2024
@provinzkraut
feat: Update MessagPack media type (#3732)
f14411a
provinzkraut added a commit that referenced this pull request Sep 23, 2024
@provinzkraut
feat: Update MessagPack media type (#3732)
62c89c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kedod kedod kedod approved these changes

@JacobCoffee JacobCoffee Awaiting requested review from JacobCoffee

Assignees
No one assigned
Labels
area/docs This PR involves changes to the documentation area/enums This PR involves changes to the enums pr/internal size: small type/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Switch to official msgpack media type
2 participants
@provinzkraut @kedod