[clang-tidy] when try to use code action to fix the function pointer not initialized problem, clang-tidy add =nullptr to the wrong place #112089

LXYan2333 · 2024-10-12T09:00:15Z

code example:

int main() {
    void(*f)(void*);
}

the function pointer f is not initialized, and clang-tidy suggest to add =nullptr to initialize it. but clang-tidy add it to a wrong position:

code example from @HighCommander4

$ cat test.cpp
int main() {
    void(*f)(void*);
}

$ clang-tidy --checks=cppcoreguidelines-init-variables --fix test.cpp
Running without flags.
1 warning generated.
test.cpp:2:11: warning: variable 'f' is not initialized [cppcoreguidelines-init-variables]
    2 |     void(*f)(void*);
      |           ^
      |             = nullptr
test.cpp:2:12: note: FIX-IT applied suggested code changes
    2 |     void(*f)(void*);
      |            ^
clang-tidy applied 1 of 1 suggested fixes.

$ cat test.cpp
int main() {
    void(*f = nullptr)(void*);
}

expected behaviour:

int main() {
    void(*f)(void*)=nullptr;
}

The text was updated successfully, but these errors were encountered:

llvmbot · 2024-10-12T09:51:17Z

@llvm/issue-subscribers-bug

Author: None (LXYan2333)

code example:

int main() {
    void(*f)(void*);
}

the function pointer f is not initialized, and clang-tidy suggest to add =nullptr to initialize it. but clang-tidy add it to a wrong position:

code example from @HighCommander4

$ cat test.cpp
int main() {
    void(*f)(void*);
}

$ clang-tidy --checks=cppcoreguidelines-init-variables --fix test.cpp
Running without flags.
1 warning generated.
test.cpp:2:11: warning: variable 'f' is not initialized [cppcoreguidelines-init-variables]
    2 |     void(*f)(void*);
      |           ^
      |             = nullptr
test.cpp:2:12: note: FIX-IT applied suggested code changes
    2 |     void(*f)(void*);
      |            ^
clang-tidy applied 1 of 1 suggested fixes.

$ cat test.cpp
int main() {
    void(*f = nullptr)(void*);
}

expected behaviour:

int main() {
    void(*f)(void*)=nullptr;
}

…uidelines-init-variables Previously, the insertion location for the `= nullptr` fix would be after the variable name. However, if the variable is of type function pointer that is not an alias, then the insertion would happen inside the type specification: `void (*a1)(void*);` -> `void (*a1 = nullptr)(void*);`. With this change, the insertion location will be at the next 'terminator'. That is, at the next `,` or `;`, as that will finish the current declaration: `void (a1)(void*) = nullptr;`. Fixes llvm#112089

github-actions bot added the clang-tidy label Oct 12, 2024

LXYan2333 mentioned this issue Oct 12, 2024

when try to use code action to fix the function pointer not initialized problem, clang-tidy add =nullptr to the wrong place clangd/clangd#2179

Closed

5chmidti self-assigned this Oct 12, 2024

5chmidti added the bug Indicates an unexpected problem or unintended behavior label Oct 12, 2024

5chmidti linked a pull request Oct 12, 2024 that will close this issue

[clang-tidy] fix insertion location for function pointers in cppcoreguidelines-init-variables #112091

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[clang-tidy] when try to use code action to fix the function pointer not initialized problem, clang-tidy add =nullptr to the wrong place #112089

[clang-tidy] when try to use code action to fix the function pointer not initialized problem, clang-tidy add =nullptr to the wrong place #112089

LXYan2333 commented Oct 12, 2024

llvmbot commented Oct 12, 2024

[clang-tidy] when try to use code action to fix the function pointer not initialized problem, clang-tidy add =nullptr to the wrong place #112089

[clang-tidy] when try to use code action to fix the function pointer not initialized problem, clang-tidy add =nullptr to the wrong place #112089

Comments

LXYan2333 commented Oct 12, 2024

llvmbot commented Oct 12, 2024