front end crash when using variadic concepts requirement with "or" statement (trunk/11)

[rgreenblatt]

Bugzilla Link	48656
Resolution	FIXED
Resolved on	Oct 11, 2021 20:29
Version	trunk
OS	Linux
Blocks	#51489
Attachments	crashes
CC	@mizvekov,@zygoloid,@tstellar
Fixed by commit(s)	e64e692 b9be17a

Extended Description

This crash occurs on trunk and on 11 with clang++ -std=c++20 FILENAME.
I think I have a pretty minimal reproduction.

template <unsigned> struct A { static constexpr bool a = true; };

template <typename T>
concept BoolOrRequirement = requires {
  requires requires {
    // any requirement (outside of a few trivial ones)
    T::b;
  } || T::a;
};

template <BoolOrRequirement...>
struct B {};

int main() {
  // need at least 2 elements for crash, more elements seems to increase
  // consistancy of crash
  B<A<0>, A<1>, A<2>, A<3>, A<4>> value;
}

Here is a godbolt link: https://godbolt.org/z/vz7Wss.
I have also attached the source file.

[rgreenblatt]

assigned to @mizvekov

[mizvekov]

*** Bug llvm/llvm-bugzilla-archive#48780 has been marked as a duplicate of this bug. ***

[mizvekov]

Fixed in main by e64e692

[tstellar]

The fix does not apply cleanly, could someone backport this and push a branch to their local github fork?

[mizvekov]

It should apply cleanly after 219790c which is the other one from me.

[mizvekov]

To make this clear, if you apply the commit from #46518 first, this one should go cleanly.

Otherwise if you want independent commits, I could rebase it.
The second one depends on the first just because of a small change to the tests added on the first one, but this was really a minor screw up on my part having added the change on the wrong patch in the original commit...

[tstellar]

Merged:

[tstellar]

Merged: b9be17a

[mizvekov]

mentioned in issue llvm/llvm-bugzilla-archive#48780

[tstellar]

mentioned in issue #51489