Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite Loop in InstCombine when Volatile memcpy are Present #50617

Closed
mohammadfawaz mannequin opened this issue Jul 29, 2021 · 3 comments
Closed

Infinite Loop in InstCombine when Volatile memcpy are Present #50617

mohammadfawaz mannequin opened this issue Jul 29, 2021 · 3 comments
Assignees
@tstellar
Labels
bugzilla Issues migrated from bugzilla tools:opt

Comments

@mohammadfawaz
Copy link
Mannequin

mohammadfawaz mannequin commented Jul 29, 2021

Bugzilla Link 51273
Resolution FIXED
Resolved on Oct 11, 2021 20:29
Version trunk
OS All
Blocks #51489
CC @LebedevRI
Fixed by commit(s) b4d945b f4b8a74

Extended Description

This issues started happening after b373b59

Basically, if the memcpy is volatile, the collectUsers() function should return false, just like we do for volatile loads.

The fix just got merged into trunk: b4d945b

The request here is to also merge the change on the 13.x branch. I believe the first change mentioned above is already on the 13.x branch.

Thanks!
@mohammadfawaz
Copy link
Mannequin Author

mohammadfawaz mannequin commented Jul 29, 2021

assigned to @tstellar

@tstellar
Copy link
Collaborator

tstellar commented Aug 5, 2021

Merged: f4b8a74

@tstellar
Copy link
Collaborator

mentioned in issue #51489

@tstellar tstellar mentioned this issue Oct 12, 2021
Closed
@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tstellar tstellar

Labels
bugzilla Issues migrated from bugzilla tools:opt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tstellar