Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge c9539f957f57c0c2c59dab98f25215f241d4debf into 13.0.1 #51897

Closed
llvmbot opened this issue Nov 19, 2021 · 7 comments
Closed

Merge c9539f957f57c0c2c59dab98f25215f241d4debf into 13.0.1 #51897

llvmbot opened this issue Nov 19, 2021 · 7 comments
Labels
bugzilla Issues migrated from bugzilla clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' release:backport release:cherry-pick-failed release:fixed-in-main release:reviewed

Comments

@llvmbot
Copy link
Collaborator

llvmbot commented Nov 19, 2021

Bugzilla Link 52555
Version unspecified
OS All
Blocks #51489
Reporter LLVM Bugzilla Contributor
CC @DimitryAndric,@nemanjai,@zygoloid,@tstellar
Fixed by commit(s) c9539f9

Extended Description

Please merge c9539f9.

[PATCH] [PowerPC] Define XL-compatible macros only for AIX and Linux

Since XLC only ever shipped on PowerPC AIX and Linux, it is not reasonable to
provide the compatibility macros on any target other than those two. This patch
restricts those macros to AIX/Linux.

@DimitryAndric
Copy link
Collaborator

Yeah having this one in 13.0.1 would be nice. We already use this in FreeBSD. :)

@tstellar
Copy link
Collaborator

Hi Unassigned,

What is your opinion on backporting this?

https://reviews.llvm.org/rGc9539f957f57c0c2c59dab98f25215f241d4debf

@DimitryAndric
Copy link
Collaborator

FWIW I brought this up originally, I think on IRC maybe even, and Nemanja implemented the fix. Nemanja, can you please give a thumbs up? :)

@nemanjai
Copy link
Member

Yes, please go ahead and merge this.

@tstellar
Copy link
Collaborator

This does not apply cleanly, can someone merge it and push the result to a github fork?

@tstellar
Copy link
Collaborator

This fix does not apply cleanly to the release branch. Could someone resolve the merge conflicts and push it to a github fork.

@tstellar
Copy link
Collaborator

Merged: 9468a0f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' release:backport release:cherry-pick-failed release:fixed-in-main release:reviewed
Projects
None yet
Development

No branches or pull requests

5 participants