-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
๐ style: support multi-window for PWA #4334
Conversation
Support multi-window on desktop devices
@BrandonStudio is attempting to deploy a commit to the LobeChat Community Team on Vercel. A member of the Team first needs to authorize it. |
๐ @BrandonStudio Thank you for raising your pull request and contributing to our Community |
Codecov ReportAll modified and coverable lines are covered by tests โ
Additional details and impacted files@@ Coverage Diff @@
## main #4334 +/- ##
========================================
Coverage 92.26% 92.26%
========================================
Files 489 489
Lines 35057 35062 +5
Branches 2133 2282 +149
========================================
+ Hits 32346 32351 +5
Misses 2711 2711
Flags with carried forward coverage won't be shown. Click here to find out more. โ View full report in Codecov by Sentry. |
้ฎไบไธ Claude๏ผ ่ฟไธช้
็ฝฎๆฏ PWA (Progressive Web App) ไธญ็ Web App Manifest ๆไปถไธญ็ไธไธชๅฑๆง๏ผ็จไบๆงๅถ PWA ๅบ็จ็ๅฏๅจ่กไธบใๅ
ทไฝๆฅ่ฏด๏ผ ่ฎฉๆไปฌ่ฏฆ็ป่งฃ้ไธไธ่ฟไธช้ ็ฝฎ๏ผ launch_handler: {
client_mode: ['navigate-existing', 'auto']
}
่ฟไธช้ ็ฝฎ็ไธป่ฆ็ฎ็ๆฏ๏ผ
้่ฆๆณจๆ็ๆฏ๏ผ ๅจๅฎ้ ๅบ็จไธญ๏ผ่ฟไธช็นๆงๅฏนไบ้ฃไบ็จๆทๅฏ่ฝ้ข็นๆๅผๅ ณ้ญ็ PWA ็นๅซๆ็จ๏ผๆฏๅฆ็คพไบคๅชไฝๅบ็จใ้ฎไปถๅฎขๆท็ซฏๆ่ ๆๆกฃ็ผ่พๅจ็ญใ |
Asked Claude: This configuration is a property in the Web App Manifest file in PWA (Progressive Web App) and is used to control the startup behavior of the PWA application. Specifically, the Let's explain this configuration in detail: launch_handler: {
client_mode: ['navigate-existing', 'auto']
}
The main purpose of this configuration is:
It should be noted that In practical applications, this feature is particularly useful for PWAs that users may frequently open and close, such as social media applications, email clients, or document editors. |
The latest updates on your projects. Learn more about Vercel for Git โ๏ธ
|
I think remove refs: https://developer.mozilla.org/en-US/docs/Web/Manifest/launch_handler |
@BrandonStudio ๆ่ฏไบไธๆไนๆฒกๅบๅซ้ขโฆ |
@BrandonStudio I tried it but there is no difference... |
ๅบ่ฏฅๆๅบๅซๅ๏ผๅจWindowsไธ๏ผ้ป่ฎค็ๅฎ่ฃ pwaไนๅ๏ผไปปๅกๆ ๆ้ผ ๆ ไธญ้ฎๅชไผๅทๆฐๅๆ็ชๅฃ๏ผไฟฎๆนไนๅ็ๅฎ่ฃ pwaๆ้ผ ๆ ไธญ้ฎไผๅบไธไธชๆฐ็ชๅฃ |
There should be a difference. On Windows, after the default installation of pwa, pressing the middle mouse button on the taskbar will only refresh the original window. After the modified installation of pwa, pressing the middle mouse button will open a new window. |
mac ไธๆฒกๅบๅซโฆ |
No difference on mac... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
โค๏ธ Great PR @BrandonStudio โค๏ธ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
### [Version 1.22.3](v1.22.2...v1.22.3) <sup>Released on **2024-10-13**</sup> #### ๐ Styles - **misc**: Support multi-windows for PWA. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Styles * **misc**: Support multi-windows for PWA, closes [#4334](#4334) ([0284606](0284606)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
๐ This PR is included in version 1.22.3 ๐ The release is available on: Your semantic-release bot ๐ฆ๐ |
้ฃๆ่งๅพๆฏmac็่ฎพ่ฎก๏ผไฝ ๅฏไปฅ่ฏ่ฏๅซ็pwaๆฏไธๆฏไนไธ่ฝๆๅผๅค็ชๅฃ๏ผๆฏๅฆclaude.ai๏ผ่ฟไธชWindowsไธไนๆฏๅฏไปฅ็ |
Then I think itโs the design of Mac. You can try to see if other pwa canโt open multiple windows, such as claude.ai, which can also be used on Windows. |
### [Version 1.65.2](v1.65.1...v1.65.2) <sup>Released on **2024-10-14**</sup> #### โป Code Refactoring - **misc**: Separate message slice and aiChat slice. #### ๐ Bug Fixes - **misc**: Fix images not go in to chat context. #### ๐ Styles - **misc**: Reorder github model list & updata info & add new model, support multi-windows for PWA. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Code refactoring * **misc**: Separate message slice and aiChat slice, closes [lobehub#4359](https:/bentwnghk/lobe-chat/issues/4359) ([7d037f6](7d037f6)) #### What's fixed * **misc**: Fix images not go in to chat context, closes [lobehub#4361](https:/bentwnghk/lobe-chat/issues/4361) ([f17ab49](f17ab49)) #### Styles * **misc**: Reorder github model list & updata info & add new model, closes [lobehub#4360](https:/bentwnghk/lobe-chat/issues/4360) ([e7767a5](e7767a5)) * **misc**: Support multi-windows for PWA, closes [lobehub#4334](https:/bentwnghk/lobe-chat/issues/4334) ([0284606](0284606)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
Support multi-window on desktop devices
๐ป ๅๆด็ฑปๅ | Change Type
๐ ๅๆด่ฏดๆ | Description of Change
Support multi-window for PWA on desktop devices.
๐ ่กฅๅ ไฟกๆฏ | Additional Information
closes #4191 #4206