Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ’„ style: disable chunking button for unsupported files #4153

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

khanhduyvt0101
Copy link
Contributor

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ‘ท build
  • โšก๏ธ perf
  • ๐Ÿ“ docs
  • ๐Ÿ”จ chore

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

Disable chunking button for unsupported files

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 26, 2024
Copy link

vercel bot commented Sep 26, 2024

@khanhduyvt0101 is attempting to deploy a commit to the LobeHub Pro Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

๐Ÿ‘ @khanhduyvt0101

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

@dosubot dosubot bot added the ๐Ÿ’„ Design Design an style | ๆ ทๅผ้—ฎ้ข˜ label Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.23%. Comparing base (9e9fb9a) to head (8ae5727).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/store/file/slices/chat/action.ts 50.00% 1 Missing โš ๏ธ
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #4153    +/-   ##
========================================
  Coverage   92.23%   92.23%            
========================================
  Files         493      494     +1     
  Lines       35500    35507     +7     
  Branches     2155     2309   +154     
========================================
+ Hits        32744    32751     +7     
  Misses       2756     2756            
Flag Coverage ฮ”
app 92.23% <87.50%> (+<0.01%) โฌ†๏ธ
server 97.37% <รธ> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@khanhduyvt0101 khanhduyvt0101 changed the title Disable chunking button for unsupported files style: disable chunking button for unsupported files Sep 26, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Sep 27, 2024
@khanhduyvt0101 khanhduyvt0101 changed the title style: disable chunking button for unsupported files ๐Ÿ’„ style: disable chunking button for unsupported files Sep 27, 2024
@khanhduyvt0101
Copy link
Contributor Author

Hi @arvinxx , Could you help me check this PR?

Copy link

vercel bot commented Sep 28, 2024

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
lobe-chat-database โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Oct 17, 2024 3:03pm
lobe-chat-preview โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Oct 17, 2024 3:03pm

@arvinxx
Copy link
Contributor

arvinxx commented Sep 28, 2024

take care of multi chunking:

image

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 29, 2024
@khanhduyvt0101
Copy link
Contributor Author

I just updated base on your feedback @arvinxx

@arvinxx
Copy link
Contributor

arvinxx commented Oct 1, 2024

I think just disable the batch chunking is not good UX way. If I have 100 files of 99 PDF and 1 image, it's really bad experience that I can't skip this 1 image. Better idea is just skip the unsupported files and batch chunk for the left files.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Oct 2, 2024
@khanhduyvt0101
Copy link
Contributor Author

I think just disable the batch chunking is not good UX way. If I have 100 files of 99 PDF and 1 image, it's really bad experience that I can't skip this 1 image. Better idea is just skip the unsupported files and batch chunk for the left files.

Hi @arvinxx , I updated code base on your review

@khanhduyvt0101
Copy link
Contributor Author

Hi @arvinxx , Could you please help me re-consider this PR?

@arvinxx
Copy link
Contributor

arvinxx commented Oct 7, 2024

@khanhduyvt0101 I'm on vocation of the Chinese National Day. I will check it at 10.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ’„ Design Design an style | ๆ ทๅผ้—ฎ้ข˜ size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants