-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
๐ style: disable chunking button for unsupported files #4153
base: main
Are you sure you want to change the base?
Conversation
@khanhduyvt0101 is attempting to deploy a commit to the LobeHub Pro Team on Vercel. A member of the Team first needs to authorize it. |
๐ @khanhduyvt0101 Thank you for raising your pull request and contributing to our Community |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4153 +/- ##
========================================
Coverage 92.23% 92.23%
========================================
Files 493 494 +1
Lines 35500 35507 +7
Branches 2155 2309 +154
========================================
+ Hits 32744 32751 +7
Misses 2756 2756
Flags with carried forward coverage won't be shown. Click here to find out more. โ View full report in Codecov by Sentry. |
Hi @arvinxx , Could you help me check this PR? |
The latest updates on your projects. Learn more about Vercel for Git โ๏ธ
|
I just updated base on your feedback @arvinxx |
I think just disable the batch chunking is not good UX way. If I have 100 files of 99 PDF and 1 image, it's really bad experience that I can't skip this 1 image. Better idea is just skip the unsupported files and batch chunk for the left files. |
Hi @arvinxx , I updated code base on your review |
Hi @arvinxx , Could you please help me re-consider this PR? |
@khanhduyvt0101 I'm on vocation of the Chinese National Day. I will check it at 10.11 |
๐ป ๅๆด็ฑปๅ | Change Type
๐ ๅๆด่ฏดๆ | Description of Change
Disable chunking button for unsupported files