ecs: add v8 preview with v1 implementation #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
yaauie
commented
Nov 5, 2021
kares
approved these changes
Nov 8, 2021
| @@ -13,7 +13,7 @@ | |||
| let(:event) { LogStash::Event.new('message' => message) } | |||
|
|
|||
| context 'with target', :ecs_compatibility_support do | |||
| ecs_compatibility_matrix(:disabled, :v1) do |ecs_select| | |||
| ecs_compatibility_matrix(:disabled, :v1, :v8 => :v1) do |ecs_select| | |||
There was a problem hiding this comment.
⛏️ the alias here is always confusing me, in the end it seems to work the same as
ecs_compatibility_matrix(:disabled, :v1, :v8)
There was a problem hiding this comment.
The :v8 => :v1 powers the ecs_select#[] aliasing, so that each invocation doesn't need to supply a :v8 lookup when it is supposed to resolve to the provided v1 lookup. In this case, we don't actually rely on the provided ecs_select too much so you are right it doesn't make a difference.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.