fix: golangci-lint error #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innobead
requested changes
Apr 26, 2024
fsops/fsops.go
Outdated
| @@ -127,7 +127,9 @@ func (f *FileSystemOperator) List(path string) ([]string, error) { | |||
| func (f *FileSystemOperator) Upload(src, dst string) error { | |||
| tmpDst := dst + ".tmp" + "." + strconv.FormatInt(time.Now().UTC().UnixNano(), 10) | |||
| if f.FileExists(tmpDst) { | |||
| f.Remove(tmpDst) | |||
| if err := f.Remove(tmpDst); err != nil { | |||
| return err | |||
There was a problem hiding this comment.
Yeah, I think we return error and for the caller to handle it. Or do you mean log it before return the error?
There was a problem hiding this comment.
In the experience, usually removing files would be best efforts, so the error could not be handled. Or, we can just have a warn log, good enough? (of course, those temp files could be leftover.)
There was a problem hiding this comment.
Agree, update to log a warning message. Thanks.
Thank you. I change the log level to warning. |
Signed-off-by: PoAn Yang <[email protected]>
innobead
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
longhorn/longhorn#7448
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context