fix: refine lock related error message #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChanYiLin
force-pushed
the
LH8713_refine_lock_err_message
branch
from
613f6d4
to
a01169c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #189 +/- ##
======================================
Coverage 7.86% 7.86%
======================================
Files 23 23
Lines 2010 2010
======================================
Hits 158 158
Misses 1826 1826
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
derekbit
reviewed
Sep 5, 2024
ChanYiLin
force-pushed
the
LH8713_refine_lock_err_message
branch
from
a01169c
to
923bd36
Compare
ref: longhorn/longhorn 8713 Signed-off-by: Jack Lin <[email protected]>
ChanYiLin
force-pushed
the
LH8713_refine_lock_err_message
branch
from
923bd36
to
f5c3c7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: longhorn/longhorn#8713
use human readable info to replace lock type in the error message to make it clear to users.