Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKPORT][v1.6.3][BUG] Fix longhorn-manager TestCleanupRedundantInstanceManagers #8670

Closed
github-actions bot opened this issue May 30, 2024 · 3 comments
Closed

[BACKPORT][v1.6.3][BUG] Fix longhorn-manager TestCleanupRedundantInstanceManagers #8670

github-actions bot opened this issue May 30, 2024 · 3 comments
Assignees
@derekbit @roger-ryao
Labels
component/longhorn-manager Longhorn manager (control plane) kind/backport Backport request kind/bug priority/0 Must be implement or fixed in this release (managed by PO) require/backport Require backport. Only used when the specific versions to backport have not been definied.
Milestone
v1.6.3

Comments

@github-actions
Copy link

backport #8658
@github-actions github-actions bot added component/longhorn-manager Longhorn manager (control plane) kind/backport Backport request kind/bug priority/0 Must be implement or fixed in this release (managed by PO) require/backport Require backport. Only used when the specific versions to backport have not been definied. require/qa-review-coverage Require QA to review coverage labels May 30, 2024
@github-actions github-actions bot added this to the v1.6.3 milestone May 30, 2024
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented May 30, 2024 •
edited by derekbit
Loading

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

#8658 (comment)

Run make test

  • Does the PR include the explanation for the fix or the feature?

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at unit test: fix newInstanceManager (backport #2831) longhorn-manager#2836

  • Which areas/issues this PR might have potential impacts on?
    Area: longhorn-manager unit test.
    Issues

@roger-ryao
Copy link

Verified on v1.6.x-head 20240905

The test steps

  1. [BACKPORT][v1.6.3][BUG] Fix longhorn-manager TestCleanupRedundantInstanceManagers #8670 (comment)

Result Passed

  1. After executing make in the longhorn/longhorn-manager codebase, the longhornio/longhorn-manager Docker image was successfully built.
  2. I ran it multiple times in the longhorn/longhorn-manager codebase without any errors.
ryao@ryao-laptop:~/Desktop/longhorn-manager/controller> go test -check.f TestCleanupRedundantInstanceManagers --count 20go: downloading go1.22.2 (linux/amd64)
W0905 18:25:50.766945     350 shared_informer.go:565] The specified resyncPeriod 30s is invalid because this shared informer doesn't support resyncing
INFO[0000] Cron is changed from  to 0 0 */7 * *. Next snapshot check job will be executed at 2024-09-08 00:00:00 +0800 CST  controller=longhorn-node monitor="snapshot monitor"
OK: 1 passed
testing arbitrary field changed
testing size update larger than threshold, 1 GiB volume
testing size update larger than threshold, 50 GiB volume
testing size update larger than threshold, 150 GiB volume
testing size update smaller than threshold, 1 GiB volume
testing size update smaller than threshold, 50 GiB volume
testing size update smaller than threshold, 150 GiB volume
testing no field changed
W0905 18:25:50.767672     350 shared_informer.go:565] The specified resyncPeriod 30s is invalid because this shared informer doesn't support resyncing
INFO[0000] Cron is changed from  to 0 0 */7 * *. Next snapshot check job will be executed at 2024-09-08 00:00:00 +0800 CST  controller=longhorn-node monitor="snapshot monitor"
OK: 1 passed
testing no field changed
testing arbitrary field changed
testing size update larger than threshold, 1 GiB volume
testing size update larger than threshold, 50 GiB volume
testing size update larger than threshold, 150 GiB volume
testing size update smaller than threshold, 1 GiB volume
testing size update smaller than threshold, 50 GiB volume
testing size update smaller than threshold, 150 GiB volume
W0905 18:25:50.768362     350 shared_informer.go:565] The specified resyncPeriod 30s is invalid because this shared informer doesn't support resyncing
INFO[0000] Cron is changed from  to 0 0 */7 * *. Next snapshot check job will be executed at 2024-09-08 00:00:00 +0800 CST  controller=longhorn-node monitor="snapshot monitor"
OK: 1 passed
testing size update smaller than threshold, 50 GiB volume
testing size update smaller than threshold, 150 GiB volume
testing no field changed
testing arbitrary field changed
testing size update larger than threshold, 1 GiB volume
testing size update larger than threshold, 50 GiB volume
testing size update larger than threshold, 150 GiB volume
testing size update smaller than threshold, 1 GiB volume
W0905 18:25:50.768918     350 shared_informer.go:565] The specified resyncPeriod 30s is invalid because this shared informer doesn't support resyncing
INFO[0000] Cron is changed from  to 0 0 */7 * *. Next snapshot check job will be executed at 2024-09-08 00:00:00 +0800 CST  controller=longhorn-node monitor="snapshot monitor"
OK: 1 passed
testing size update larger than threshold, 150 GiB volume
testing size update smaller than threshold, 1 GiB volume
testing size update smaller than threshold, 50 GiB volume
testing size update smaller than threshold, 150 GiB volume
testing no field changed
testing arbitrary field changed
testing size update larger than threshold, 1 GiB volume
testing size update larger than threshold, 50 GiB volume
W0905 18:25:50.770136     350 shared_informer.go:565] The specified resyncPeriod 30s is invalid because this shared informer doesn't support resyncing
INFO[0000] Cron is changed from  to 0 0 */7 * *. Next snapshot check job will be executed at 2024-09-08 00:00:00 +0800 CST  controller=longhorn-node monitor="snapshot monitor"
OK: 1 passed
testing no field changed
testing arbitrary field changed
testing size update larger than threshold, 1 GiB volume
testing size update larger than threshold, 50 GiB volume
testing size update larger than threshold, 150 GiB volume
testing size update smaller than threshold, 1 GiB volume
testing size update smaller than threshold, 50 GiB volume
testing size update smaller than threshold, 150 GiB volume
W0905 18:25:50.770766     350 shared_informer.go:565] The specified resyncPeriod 30s is invalid because this shared informer doesn't support resyncing
INFO[0000] Cron is changed from  to 0 0 */7 * *. Next snapshot check job will be executed at 2024-09-08 00:00:00 +0800 CST  controller=longhorn-node monitor="snapshot monitor"
OK: 1 passed
testing size update larger than threshold, 150 GiB volume
testing size update smaller than threshold, 1 GiB volume
testing size update smaller than threshold, 50 GiB volume
testing size update smaller than threshold, 150 GiB volume
testing no field changed
testing arbitrary field changed
testing size update larger than threshold, 1 GiB volume
testing size update larger than threshold, 50 GiB volume
W0905 18:25:50.771335     350 shared_informer.go:565] The specified resyncPeriod 30s is invalid because this shared informer doesn't support resyncing
INFO[0000] Cron is changed from  to 0 0 */7 * *. Next snapshot check job will be executed at 2024-09-08 00:00:00 +0800 CST  controller=longhorn-node monitor="snapshot monitor"
OK: 1 passed
testing size update smaller than threshold, 1 GiB volume
testing size update smaller than threshold, 50 GiB volume
testing size update smaller than threshold, 150 GiB volume
testing no field changed
testing arbitrary field changed
testing size update larger than threshold, 1 GiB volume
testing size update larger than threshold, 50 GiB volume
testing size update larger than threshold, 150 GiB volume
W0905 18:25:50.771860     350 shared_informer.go:565] The specified resyncPeriod 30s is invalid because this shared informer doesn't support resyncing
INFO[0000] Cron is changed from  to 0 0 */7 * *. Next snapshot check job will be executed at 2024-09-08 00:00:00 +0800 CST  controller=longhorn-node monitor="snapshot monitor"
OK: 1 passed
testing size update smaller than threshold, 50 GiB volume
testing size update smaller than threshold, 150 GiB volume
testing no field changed
testing arbitrary field changed
testing size update larger than threshold, 1 GiB volume
testing size update larger than threshold, 50 GiB volume
testing size update larger than threshold, 150 GiB volume
testing size update smaller than threshold, 1 GiB volume
W0905 18:25:50.772404     350 shared_informer.go:565] The specified resyncPeriod 30s is invalid because this shared informer doesn't support resyncing
INFO[0000] Cron is changed from  to 0 0 */7 * *. Next snapshot check job will be executed at 2024-09-08 00:00:00 +0800 CST  controller=longhorn-node monitor="snapshot monitor"
OK: 1 passed
testing size update larger than threshold, 1 GiB volume
testing size update larger than threshold, 50 GiB volume
testing size update larger than threshold, 150 GiB volume
testing size update smaller than threshold, 1 GiB volume
testing size update smaller than threshold, 50 GiB volume
testing size update smaller than threshold, 150 GiB volume
testing no field changed
testing arbitrary field changed
W0905 18:25:50.772880     350 shared_informer.go:565] The specified resyncPeriod 30s is invalid because this shared informer doesn't support resyncing
INFO[0000] Cron is changed from  to 0 0 */7 * *. Next snapshot check job will be executed at 2024-09-08 00:00:00 +0800 CST  controller=longhorn-node monitor="snapshot monitor"
OK: 1 passed
testing size update smaller than threshold, 150 GiB volume
testing no field changed
testing arbitrary field changed
testing size update larger than threshold, 1 GiB volume
testing size update larger than threshold, 50 GiB volume
testing size update larger than threshold, 150 GiB volume
testing size update smaller than threshold, 1 GiB volume
testing size update smaller than threshold, 50 GiB volume
W0905 18:25:50.773488     350 shared_informer.go:565] The specified resyncPeriod 30s is invalid because this shared informer doesn't support resyncing
INFO[0000] Cron is changed from  to 0 0 */7 * *. Next snapshot check job will be executed at 2024-09-08 00:00:00 +0800 CST  controller=longhorn-node monitor="snapshot monitor"
OK: 1 passed
testing size update larger than threshold, 50 GiB volume
testing size update larger than threshold, 150 GiB volume
testing size update smaller than threshold, 1 GiB volume
testing size update smaller than threshold, 50 GiB volume
testing size update smaller than threshold, 150 GiB volume
testing no field changed
testing arbitrary field changed
testing size update larger than threshold, 1 GiB volume
W0905 18:25:50.774078     350 shared_informer.go:565] The specified resyncPeriod 30s is invalid because this shared informer doesn't support resyncing
INFO[0000] Cron is changed from  to 0 0 */7 * *. Next snapshot check job will be executed at 2024-09-08 00:00:00 +0800 CST  controller=longhorn-node monitor="snapshot monitor"
OK: 1 passed
testing size update smaller than threshold, 50 GiB volume
testing size update smaller than threshold, 150 GiB volume
testing no field changed
testing arbitrary field changed
testing size update larger than threshold, 1 GiB volume
testing size update larger than threshold, 50 GiB volume
testing size update larger than threshold, 150 GiB volume
testing size update smaller than threshold, 1 GiB volume
W0905 18:25:50.774863     350 shared_informer.go:565] The specified resyncPeriod 30s is invalid because this shared informer doesn't support resyncing
INFO[0000] Cron is changed from  to 0 0 */7 * *. Next snapshot check job will be executed at 2024-09-08 00:00:00 +0800 CST  controller=longhorn-node monitor="snapshot monitor"
OK: 1 passed
testing size update larger than threshold, 1 GiB volume
testing size update larger than threshold, 50 GiB volume
testing size update larger than threshold, 150 GiB volume
testing size update smaller than threshold, 1 GiB volume
testing size update smaller than threshold, 50 GiB volume
testing size update smaller than threshold, 150 GiB volume
testing no field changed
testing arbitrary field changed
W0905 18:25:50.776040     350 shared_informer.go:565] The specified resyncPeriod 30s is invalid because this shared informer doesn't support resyncing
INFO[0000] Cron is changed from  to 0 0 */7 * *. Next snapshot check job will be executed at 2024-09-08 00:00:00 +0800 CST  controller=longhorn-node monitor="snapshot monitor"
OK: 1 passed
testing no field changed
testing arbitrary field changed
testing size update larger than threshold, 1 GiB volume
testing size update larger than threshold, 50 GiB volume
testing size update larger than threshold, 150 GiB volume
testing size update smaller than threshold, 1 GiB volume
testing size update smaller than threshold, 50 GiB volume
testing size update smaller than threshold, 150 GiB volume
W0905 18:25:50.776665     350 shared_informer.go:565] The specified resyncPeriod 30s is invalid because this shared informer doesn't support resyncing
INFO[0000] Cron is changed from  to 0 0 */7 * *. Next snapshot check job will be executed at 2024-09-08 00:00:00 +0800 CST  controller=longhorn-node monitor="snapshot monitor"
OK: 1 passed
testing size update larger than threshold, 1 GiB volume
testing size update larger than threshold, 50 GiB volume
testing size update larger than threshold, 150 GiB volume
testing size update smaller than threshold, 1 GiB volume
testing size update smaller than threshold, 50 GiB volume
testing size update smaller than threshold, 150 GiB volume
testing no field changed
testing arbitrary field changed
W0905 18:25:50.777230     350 shared_informer.go:565] The specified resyncPeriod 30s is invalid because this shared informer doesn't support resyncing
INFO[0000] Cron is changed from  to 0 0 */7 * *. Next snapshot check job will be executed at 2024-09-08 00:00:00 +0800 CST  controller=longhorn-node monitor="snapshot monitor"
OK: 1 passed
testing size update larger than threshold, 1 GiB volume
testing size update larger than threshold, 50 GiB volume
testing size update larger than threshold, 150 GiB volume
testing size update smaller than threshold, 1 GiB volume
testing size update smaller than threshold, 50 GiB volume
testing size update smaller than threshold, 150 GiB volume
testing no field changed
testing arbitrary field changed
W0905 18:25:50.777860     350 shared_informer.go:565] The specified resyncPeriod 30s is invalid because this shared informer doesn't support resyncing
INFO[0000] Cron is changed from  to 0 0 */7 * *. Next snapshot check job will be executed at 2024-09-08 00:00:00 +0800 CST  controller=longhorn-node monitor="snapshot monitor"
OK: 1 passed
testing size update smaller than threshold, 150 GiB volume
testing no field changed
testing arbitrary field changed
testing size update larger than threshold, 1 GiB volume
testing size update larger than threshold, 50 GiB volume
testing size update larger than threshold, 150 GiB volume
testing size update smaller than threshold, 1 GiB volume
testing size update smaller than threshold, 50 GiB volume
W0905 18:25:50.778446     350 shared_informer.go:565] The specified resyncPeriod 30s is invalid because this shared informer doesn't support resyncing
INFO[0000] Cron is changed from  to 0 0 */7 * *. Next snapshot check job will be executed at 2024-09-08 00:00:00 +0800 CST  controller=longhorn-node monitor="snapshot monitor"
OK: 1 passed
testing arbitrary field changed
testing size update larger than threshold, 1 GiB volume
testing size update larger than threshold, 50 GiB volume
testing size update larger than threshold, 150 GiB volume
testing size update smaller than threshold, 1 GiB volume
testing size update smaller than threshold, 50 GiB volume
testing size update smaller than threshold, 150 GiB volume
testing no field changed
W0905 18:25:50.779033     350 shared_informer.go:565] The specified resyncPeriod 30s is invalid because this shared informer doesn't support resyncing
INFO[0000] Cron is changed from  to 0 0 */7 * *. Next snapshot check job will be executed at 2024-09-08 00:00:00 +0800 CST  controller=longhorn-node monitor="snapshot monitor"
OK: 1 passed
testing size update larger than threshold, 150 GiB volume
testing size update smaller than threshold, 1 GiB volume
testing size update smaller than threshold, 50 GiB volume
testing size update smaller than threshold, 150 GiB volume
testing no field changed
testing arbitrary field changed
testing size update larger than threshold, 1 GiB volume
testing size update larger than threshold, 50 GiB volume
W0905 18:25:50.779599     350 shared_informer.go:565] The specified resyncPeriod 30s is invalid because this shared informer doesn't support resyncing
INFO[0000] Cron is changed from  to 0 0 */7 * *. Next snapshot check job will be executed at 2024-09-08 00:00:00 +0800 CST  controller=longhorn-node monitor="snapshot monitor"
OK: 1 passed
testing size update smaller than threshold, 50 GiB volume
testing size update smaller than threshold, 150 GiB volume
testing no field changed
testing arbitrary field changed
testing size update larger than threshold, 1 GiB volume
testing size update larger than threshold, 50 GiB volume
testing size update larger than threshold, 150 GiB volume
testing size update smaller than threshold, 1 GiB volume
PASS
ok      github.com/longhorn/longhorn-manager/controller 0.032s

@roger-ryao
Copy link

Remove the require/qa-review-coverage label because the review is complete and no further action is required for this ticket.

@roger-ryao roger-ryao removed the require/qa-review-coverage Require QA to review coverage label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekbit derekbit

@roger-ryao roger-ryao

Labels
component/longhorn-manager Longhorn manager (control plane) kind/backport Backport request kind/bug priority/0 Must be implement or fixed in this release (managed by PO) require/backport Require backport. Only used when the specific versions to backport have not been definied.
Projects
Longhorn Sprint
Status: Closed
Milestone
v1.6.3
Development

No branches or pull requests
3 participants
@derekbit @longhorn-io-github-bot @roger-ryao