Add mongo package dependancy

[frco9]

Since I’ve updated meteor to v1.4.3.1,
I got an error in the client :

Uncaught ReferenceError: Mongo is not defined
    at lookback_seo.js?hash=0bf747b…:281
    at lookback_seo.js?hash=0bf747b…:473
    at lookback_seo.js?hash=0bf747b…:480
(anonymous) @ lookback_seo.js?hash=0bf747b…:281
(anonymous) @ lookback_seo.js?hash=0bf747b…:473
(anonymous) @ lookback_seo.js?hash=0bf747b…:480

This pull request fix it

[johanbrook]

Thanks! But where is Mongo referred to in this package? Can't find it.

[frco9]

That's the weird part ; In the tests, and I couldn't figure why Meteor execute them.

[johanbrook]

Does adding mongo to https:/lookback/meteor-seo/blob/master/test-app/.meteor/packages help? But I guess it should be included in the meteor-platform package.

[frco9]

Yes it helps, I've committed changes. Maybe its not in meteor-plaform anymore ?
https:/meteor/meteor/blob/devel/History.md#v143-2017-02-13

[johanbrook]

Probably not, those tests were written a long time ago.

Ready to merge?

[frco9]

All good for me !

[johanbrook]

Sweeters, thanks mate ✨

[Nekomant]

[email protected]
lookback:[email protected]

Error is still here.

Where i can find uncompiled file for check dependencies?

[johanbrook]

Dependencies?

Looks like source maps aren't working in that screenshot.

[frco9]

Well indeed the build failed in staging but I hadn't time to look at it until now.

On my dev env I had a symlink of the repo inside my packages folder for testing and it still works. But if I get the package from atmosphere it's not working.

I'll look at it more closely tomorrow

[etheleon]

any updates on this?

@frco9 you mean u cloned the github repo and have meteor use the local copy instead of the atmosphere package right?

[frco9]

Yes, I couldn't figure out why, but if I git clone the master branch inside my packages folder it's working fine. But if I'm using the atmosphere one its not working :/
Maybe something cache related ???

[w3jimmy]

I still have this issue...

This error is shown after deployment in production, but not while in development.
If I remove this package (lookback seo)it works fine, but I'd like to put it back.

I'm using Meteor 1.4.4.2 and these are the packages versions:
iron:[email protected]
iron:[email protected]
iron:[email protected]
iron:[email protected]
iron:[email protected]
iron:[email protected]
iron:[email protected]
iron:[email protected]

I tried adding [email protected]

please help, thanks