-
-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CancellationTokenSource not disposed #1234
Comments
louthy
added a commit
that referenced
this issue
Aug 7, 2023
Good spot! Fix is done and will be deployed this week 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
for the following code, in
struct Aff<RT, A>.Timeout
, it will callenv.LocalCancel
to create a newCancellationTokenSource
.if task is complete before the timeout, I don't see place to dispose the lenv.CancellationTokenSource.
Maybe this is not a best practice, since Microsoft docs suggests that we should dispose a CancellationTokenSource when complete.
Thanks,
The text was updated successfully, but these errors were encountered: