Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clkmgr, fpga] Enhance clkmgr to allow for different types of clock gates per module #11073

Open
tjaychen opened this issue Feb 24, 2022 · 5 comments
Labels
Component:FPGA FPGA related issues Earlgrey-PROD Triaged Temporary label to triage issues into Earlgrey-PROD Milestones IP:clkmgr Priority:P2 Priority: medium TOP:earlgrey Type:FutureRelease Not relevant to currently planned releases/milestones
Milestone

Comments

@tjaychen
Copy link

Specifically, allow additional attributes in the top hjson file to specify what kind of FPGA clock gates a particular module should use.
See #11063 for motivation.

@tjaychen
Copy link
Author

@vogelpi FYI

@tjaychen tjaychen added Component:FPGA FPGA related issues IP:clkmgr Priority:P2 Priority: medium TOP:earlgrey Type:Enhancement Feature requests, enhancements labels Feb 24, 2022
@vogelpi
Copy link
Contributor

vogelpi commented Feb 24, 2022

Cool, thanks for creating this issue @tjaychen . Automating this based on the top-level sounds like a good idea.

@tjaychen tjaychen added Type:FutureRelease Not relevant to currently planned releases/milestones and removed Type:Enhancement Feature requests, enhancements labels Apr 15, 2022
@andreaskurth
Copy link
Contributor

Triaged for clkmgr. I think this isn't needed for the current release, so Type:FutureRelease Not relevant to currently planned releases/milestones seems appropriate.

@msfschaffner
Copy link
Contributor

CC @a-will

@msfschaffner msfschaffner added this to the Backlog milestone Oct 6, 2023
@msfschaffner msfschaffner added the Earlgrey-PROD Triaged Temporary label to triage issues into Earlgrey-PROD Milestones label Oct 6, 2023
@a-will
Copy link
Contributor

a-will commented Oct 6, 2023

This can actually be specified with prim-specific localparams + hierarchical paths to set it from the chip_* layer (which can come from either the template or hjson, depending on implementation in topgen). I initially did this with spi_device for CW340, but then I found a different way (converted some of the higher-layer clock prims to abstract).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:FPGA FPGA related issues Earlgrey-PROD Triaged Temporary label to triage issues into Earlgrey-PROD Milestones IP:clkmgr Priority:P2 Priority: medium TOP:earlgrey Type:FutureRelease Not relevant to currently planned releases/milestones
Projects
None yet
Development

No branches or pull requests

5 participants