Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dv/rstmgr] Apply different reset kinds where applicable #16148

Closed
matutem opened this issue Nov 9, 2022 · 8 comments
Closed

[dv/rstmgr] Apply different reset kinds where applicable #16148

matutem opened this issue Nov 9, 2022 · 8 comments
Labels
Component:DV DV issue: testbench, test case, etc. Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:rstmgr Priority:P2 Priority: medium

Comments

@matutem
Copy link
Contributor

matutem commented Nov 9, 2022

Most unit tests use the default apply_reset kind argument. The rstmgr unit has both AON and non-AON domain components, so the apply_reset distinction is important. One way to exercise it could be to call apply_reset with a randomized kind argument between rounds of various tests.

estimate 8

@matutem matutem self-assigned this Nov 9, 2022
@matutem matutem added the Component:DV DV issue: testbench, test case, etc. label Nov 9, 2022
@matutem matutem added this to the Project: M3 milestone Nov 9, 2022
@sriyerg
Copy link
Contributor

sriyerg commented Nov 9, 2022

Please see example:

if (kind inside {"HARD", "TRST"}) begin

For rv_dm I defined 3 different reset strings with the same goal as yours - be able to apply different kinds of resets randomly and verify expected behavior.

@andreaskurth
Copy link
Contributor

Triaged for pwrmgr. Assigning to M2.5 with Priority:P2 Priority: medium because this would increase coverage around resets, which IMO is relevant.

@andreaskurth andreaskurth added Priority:P2 Priority: medium Triaging:MultipleBlocks Issue is relevant for the triage of multiple HW blocks labels Feb 23, 2023
@GregAC
Copy link
Contributor

GregAC commented Feb 23, 2023

Triaged for rstmgr, agree with @andreaskurth

@GregAC
Copy link
Contributor

GregAC commented Mar 22, 2023

Estimate range: 4 - 8

@andreaskurth
Copy link
Contributor

Triaged for clkmgr (sorry this somehow slipped my filters), agreed on Priority:P2 Priority: medium

@andreaskurth andreaskurth added Triaged and removed Triaging:MultipleBlocks Issue is relevant for the triage of multiple HW blocks labels Mar 22, 2023
@msfschaffner
Copy link
Contributor

msfschaffner commented Apr 10, 2023

Discussed with @matutem - this seems to be a coverage closure exercise that can be done after M2.5.
We have many TLT's that already stress the interconnected reset behaviors of the *mgr's.

@msfschaffner msfschaffner added the Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones label Oct 7, 2023
This was referenced Feb 17, 2024
@matutem matutem changed the title [dv/clk/pwr/rstmgr] Apply different reset kinds where applicable [dv/rstmgr] Apply different reset kinds where applicable Feb 22, 2024
@matutem
Copy link
Contributor Author

matutem commented Feb 22, 2024

I undated the issue to state it only applies to rstmgr, not clk or pwrmgr.

@matutem
Copy link
Contributor Author

matutem commented Aug 20, 2024

In rstmgr_reset_vseq we apply random resets, which include hard (aon) and regular resets, so this issue can be declared complete.

@matutem matutem closed this as completed Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:DV DV issue: testbench, test case, etc. Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:rstmgr Priority:P2 Priority: medium
Projects
None yet
Development

No branches or pull requests

6 participants