Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[edn/dv] V2S TODOs #16268

Closed
4 tasks done
cindychip opened this issue Nov 11, 2022 · 3 comments
Closed
4 tasks done

[edn/dv] V2S TODOs #16268

cindychip opened this issue Nov 11, 2022 · 3 comments
Assignees
Milestone

Comments

@cindychip
Copy link
Contributor

cindychip commented Nov 11, 2022

  • [Steve]: Could you help check with Mark and see if we can unify the local_escalate_i and edn_enable_i at the end of the state machine case statement.

  • [Cindy]: Add assertions to check if local escalation can trigger fatal alerts. Currently file an issue

  • [Cindy] Increase the length of genbits request. (Current max is 16/4?)
    [dv/edn] Increase edn genbit max size #16297

  • [Cindy] Randomly drives max_reqs_after_reseed when not in auto_req_mode.

@cindychip cindychip added this to the Project: M2 milestone Nov 11, 2022
@senelson7
Copy link
Contributor

I checked with Mark, and we think we used to have it that way but changed it for some reason. Anyways, we can't think of any reason the local_escalate_i -> Error, edn_enable_i -> Idle can't be done outside of the State/case statement.

@cindychip
Copy link
Contributor Author

I checked with Mark, and we think we used to have it that way but changed it for some reason. Anyways, we can't think of any reason the local_escalate_i -> Error, edn_enable_i -> Idle can't be done outside of the State/case statement.

That is awesome, thank you Steve and Mark for confirming that. Do you want our side to make a PR for that, or do you want to do it. Either way is fine for me :)

@cindychip
Copy link
Contributor Author

All items are done, just wait for coverage to reach 90%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants