Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clkmgr] Template exclusions #16640

Closed
tjaychen opened this issue Dec 2, 2022 · 2 comments · Fixed by #22891
Closed

[clkmgr] Template exclusions #16640

tjaychen opened this issue Dec 2, 2022 · 2 comments · Fixed by #22891
Labels
Component:DV DV issue: testbench, test case, etc. Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:clkmgr Type:Icebox Changes deferred to future milestones
Milestone
Earlgrey-PROD.M4

Comments

@tjaychen
Copy link

tjaychen commented Dec 2, 2022 •
edited
Loading

As part of #16625 (thanks @matutem), some clkmgr exclusions were manually written to exclude nets that are not used.
Similar to rstmgr, we should auto generate these for better long term maintenance.
@tjaychen tjaychen added this to the Project: M3 milestone Dec 2, 2022
@andreaskurth
Copy link
Contributor

Triaged for clkmgr. Labeling Type:Icebox Changes deferred to future milestones because this seems to be a cleanup that is not necessary for M2.5.

@andreaskurth andreaskurth added Component:DV DV issue: testbench, test case, etc. IP:clkmgr Type:Icebox Changes deferred to future milestones Triaged labels Feb 27, 2023
@msfschaffner
Copy link
Contributor

CC @matutem

@msfschaffner msfschaffner added the Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones label Oct 7, 2023
@msfschaffner msfschaffner mentioned this issue Feb 15, 2024
Closed
This was referenced Feb 15, 2024
Closed
Closed
@matutem matutem mentioned this issue Feb 22, 2024
Closed
matutem added a commit to matutem/opentitan that referenced this issue Apr 30, 2024
@matutem
[dv,clkmgr] Generate node toggle exclusions from hjson
6e50fb9 
This creates a template file to exclude some nodes related to clock
gating tied to constants.
Use `module_node` for the block level toggle exclusion configs to
enable using the same config at the top level.

Fixes lowRISC#16640

Signed-off-by: Guillermo Maturana <[email protected]>
matutem added a commit to matutem/opentitan that referenced this issue Apr 30, 2024
@matutem
[dv,rstmgr] Generate node toggle exclusions from hjson
53023d2 
This creates a template file to exclude some output resets and reset enables
tied to constants.
Use `module_node` for the block level toggle exclusion configs to
enable using the same config at the top level.

Fixes lowRISC#16640

Signed-off-by: Guillermo Maturana <[email protected]>
matutem added a commit to matutem/opentitan that referenced this issue Apr 30, 2024
@matutem
[dv,top_level] Fix coverage toggle exclusion configs
3dbe4b1 
Use `module_node` for the block level toggle exclusion configs.
This enables using the same config at the top level.

Fixes lowRISC#16640

Signed-off-by: Guillermo Maturana <[email protected]>
@matutem matutem mentioned this issue Apr 30, 2024
Merged
matutem added a commit to matutem/opentitan that referenced this issue Apr 30, 2024
@matutem
[dv,top_level] Fix coverage toggle exclusion configs
57ab246 
Use `module_node` for the block level toggle exclusion configs.
This enables using the same config at the top level.

Fixes lowRISC#16640

Signed-off-by: Guillermo Maturana <[email protected]>
matutem added a commit that referenced this issue Apr 30, 2024
@matutem
[dv,clkmgr] Generate node toggle exclusions from hjson
a162fb5 
This creates a template file to exclude some nodes related to clock
gating tied to constants.
Use `module_node` for the block level toggle exclusion configs to
enable using the same config at the top level.

Fixes #16640

Signed-off-by: Guillermo Maturana <[email protected]>
matutem added a commit that referenced this issue Apr 30, 2024
@matutem
[dv,rstmgr] Generate node toggle exclusions from hjson
71fe7b4 
This creates a template file to exclude some output resets and reset enables
tied to constants.
Use `module_node` for the block level toggle exclusion configs to
enable using the same config at the top level.

Fixes #16640

Signed-off-by: Guillermo Maturana <[email protected]>
matutem added a commit that referenced this issue Apr 30, 2024
@matutem
[dv,top_level] Fix coverage toggle exclusion configs
e9925bd 
Use `module_node` for the block level toggle exclusion configs.
This enables using the same config at the top level.

Fixes #16640

Signed-off-by: Guillermo Maturana <[email protected]>
AlexJones0 pushed a commit to AlexJones0/opentitan that referenced this issue Jul 8, 2024
@matutem @AlexJones0
[dv,clkmgr] Generate node toggle exclusions from hjson
53163e3 
This creates a template file to exclude some nodes related to clock
gating tied to constants.
Use `module_node` for the block level toggle exclusion configs to
enable using the same config at the top level.

Fixes lowRISC#16640

Signed-off-by: Guillermo Maturana <[email protected]>
AlexJones0 pushed a commit to AlexJones0/opentitan that referenced this issue Jul 8, 2024
@matutem @AlexJones0
[dv,rstmgr] Generate node toggle exclusions from hjson
dc8c414 
This creates a template file to exclude some output resets and reset enables
tied to constants.
Use `module_node` for the block level toggle exclusion configs to
enable using the same config at the top level.

Fixes lowRISC#16640

Signed-off-by: Guillermo Maturana <[email protected]>
AlexJones0 pushed a commit to AlexJones0/opentitan that referenced this issue Jul 8, 2024
@matutem @AlexJones0
[dv,top_level] Fix coverage toggle exclusion configs
f00746b 
Use `module_node` for the block level toggle exclusion configs.
This enables using the same config at the top level.

Fixes lowRISC#16640

Signed-off-by: Guillermo Maturana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component:DV DV issue: testbench, test case, etc. Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:clkmgr Type:Icebox Changes deferred to future milestones
Projects
None yet
Milestone
Earlgrey-PROD.M4
Development

Successfully merging a pull request may close this issue.

[dv,cov] Improve config for toggle coverage exclusions matutem/opentitan
4 participants
@tjaychen @andreaskurth @msfschaffner @jeoongp