Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ip,doc] Fix inaccurate references to reset behavior #20700

Closed
matutem opened this issue Dec 21, 2023 · 0 comments · Fixed by #20738
Closed

[ip,doc] Fix inaccurate references to reset behavior #20700

matutem opened this issue Dec 21, 2023 · 0 comments · Fixed by #20738
Assignees
@matutem
Labels
Component:Doc Documentation issue Milestone:V3 Priority:P2 Priority: medium
Milestone
Earlgrey-PROD.M3

Comments

@matutem
Copy link
Contributor

matutem commented Dec 21, 2023

Description
@matutem matutem self-assigned this Dec 21, 2023
@matutem matutem added Component:Doc Documentation issue Priority:P2 Priority: medium Milestone:V3 labels Dec 21, 2023
@matutem matutem added this to the Earlgrey-PROD.M3 milestone Dec 21, 2023
matutem added a commit to matutem/opentitan that referenced this issue Dec 26, 2023
@matutem
[doc,reset] Fix references to reset behavior
b22f13f 
- Don't mention the reset topology in the lc_ctrl theory of operation doc's
  description of CPU_EN since lc_cpu_en_o is independent of reset, and
  rv_core_ibex gets a separate fetch_en input from pwrmgr that determines
  whether the cpu is effectively enabled.
- Fix the life cycle control description in the rv_dm interfaces doc: all
  it needs to say is that NDM reset will not reset rv_dm but will reset
  lc_ctrl. The prior text is inaccurate.

Fixes lowRISC#20700

Signed-off-by: Guillermo Maturana <[email protected]>
@matutem matutem mentioned this issue Dec 27, 2023
Merged
matutem added a commit to matutem/opentitan that referenced this issue Jan 3, 2024
@matutem
[doc,reset] Fix references to reset behavior
0f5fa14 
- Don't mention the reset topology in the lc_ctrl theory of operation doc's
  description of CPU_EN since lc_cpu_en_o is independent of reset, and
  rv_core_ibex gets a separate fetch_en input from pwrmgr that determines
  whether the cpu is effectively enabled.
- Fix the life cycle control description in the rv_dm interfaces doc: all
  it needs to say is that NDM reset will not reset rv_dm but will reset
  lc_ctrl. The prior text is inaccurate.

Fixes lowRISC#20700

Signed-off-by: Guillermo Maturana <[email protected]>
matutem added a commit that referenced this issue Jan 3, 2024
@matutem
[doc,reset] Fix references to reset behavior
637d1b8 
- Don't mention the reset topology in the lc_ctrl theory of operation doc's
  description of CPU_EN since lc_cpu_en_o is independent of reset, and
  rv_core_ibex gets a separate fetch_en input from pwrmgr that determines
  whether the cpu is effectively enabled.
- Fix the life cycle control description in the rv_dm interfaces doc: all
  it needs to say is that NDM reset will not reset rv_dm but will reset
  lc_ctrl. The prior text is inaccurate.

Fixes #20700

Signed-off-by: Guillermo Maturana <[email protected]>
@msfschaffner msfschaffner mentioned this issue Feb 15, 2024
Closed
This was referenced Feb 15, 2024
Closed
Closed
@matutem matutem mentioned this issue Feb 22, 2024
Closed
@rswarbrick rswarbrick mentioned this issue Feb 23, 2024
Closed
@matutem matutem mentioned this issue Feb 26, 2024
Closed
@GregAC GregAC mentioned this issue Mar 8, 2024
Closed
@matutem matutem mentioned this issue Mar 8, 2024
Closed
@msfschaffner msfschaffner mentioned this issue Mar 15, 2024
Closed
@GregAC GregAC mentioned this issue Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matutem matutem

Labels
Component:Doc Documentation issue Milestone:V3 Priority:P2 Priority: medium
Projects
None yet
Milestone
Earlgrey-PROD.M3
Development

Successfully merging a pull request may close this issue.

[doc,reset] Fix references to reset behavior matutem/opentitan
1 participant
@matutem