[entropy complex/security] countermeasure lists and labels updated #10118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assets and countermeasure labels have been added. Signed-off-by: Mark Branstad <[email protected]>
mwbranstad
changed the title
mwbranstad
changed the title
This was referenced Jan 17, 2022
Closed
cdgori
reviewed
Jan 19, 2022
| { name: "FSM.SPARSE" | ||
| desc: "Sparse state machine implementation." | ||
| } | ||
| { name: "RNG.BKGN_CHK" | ||
| desc: "Random number generater is protected with continuous background health checks." |
cdgori
reviewed
Jan 19, 2022
hw/ip/csrng/data/csrng.hjson
Outdated
| { name: "FSM.SPARSE" | ||
| desc: "Sparse state machine implementation." | ||
| } | ||
| { name: "CTR.REDUN" | ||
| desc: "Counter hardening for generate command counter." | ||
| } | ||
| { name: "LOGIC.INTEGRITY" | ||
| { name: "SW_GENBITS.BUS.INTEGRITY" |
There was a problem hiding this comment.
INTEGRITY -> CONSISTENCY for these consecutive values checks
cdgori
reviewed
Jan 19, 2022
hw/ip/edn/data/edn.hjson
Outdated
| { name: "FSM.SPARSE" | ||
| desc: "Sparse state machine implementation." | ||
| } | ||
| { name: "CTR.REDUN" | ||
| desc: "Counter hardening on the generate command maximum requests counter." | ||
| } | ||
| { name: "LOGIC.INTEGRITY" | ||
| { name: "CS_RDATA.BUS.INTEGRITY" |
There was a problem hiding this comment.
INTEGRITY -> CONSISTENCY for these consecutive values checks
cdgori
reviewed
Jan 19, 2022
| { name: "CTR.REDUN" | ||
| desc: "Counter hardening for all health test counters." | ||
| } | ||
| { name: "LOGIC.INTEGRITY" | ||
| { name: "ESFINAL_RDATA.BUS.INTEGRITY" |
There was a problem hiding this comment.
INTEGRITY -> CONSISTENCY for these consecutive values checks
|
Please adjust per comments above, the rest LGTM as we discussed offline. Note: we didn't fully review EDN changes in this PR yet so maybe hold it until D2S for EDN is complete and AIs compiled/addressed? You'll also need to add another reviewer with commit rights or this will be stuck. It won't even let me start a "review" because of the missing committer. |
For all entropy complex blocks, the countermeasure lists for all assets have been updated. Instant labels have also been assigned near each asset within the RTL. Signed-off-by: Mark Branstad <[email protected]>
|
this looks good to me. |
tjaychen
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.