[entropy complex blocks] D2S reviews completed #10486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdgori
requested review from
cdgori,
tjaychen,
vogelpi,
msfschaffner and
moidx
|
I'll mark this as ready for review with the understanding that it should not be merged until the other PRs you mentioned have landed. |
Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner
force-pushed
the
ec_d2sdone
branch
from
5a24b86
to
3178cca
Compare
Approval of this PR will close all related review issues and signify that entropy_src, csrng, and edn blocks have completed D2S checkpoints. Closes lowRISC#10095. Closes lowRISC#10096. Closes lowRISC#10262. Signed-off-by: Mark Branstad <[email protected]> Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner
force-pushed
the
ec_d2sdone
branch
from
3178cca
to
1975347
Compare
|
@mwbranstad I realized that not all D2S checklist items have been checked off. |
|
Alright, all updates should be in by now. If we all agree that #9853 does not gate D2S, we can move this in and declare D2S for the entropy complex. |
msfschaffner
approved these changes
Feb 7, 2022
|
Thanks for checking @cdgori. I think we can proceed then. If anyone spots something that slipped through the cracks, please reach out or flag it via an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approval of this PR will close all related review issues and signify
that entropy_src, csrng, and edn blocks have completed D2S checkpoints.
Closes #10095.
Closes #10096.
Closes #10262.
Signed-off-by: Mark Branstad [email protected]