Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[entropy_src/dv] Extend toggle coverage refines #16256

Closed
wants to merge 2 commits into from
Closed

[entropy_src/dv] Extend toggle coverage refines #16256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1ec738
[entropy_src/dv] Exclude `entropy_src_xht_o` from toggle coverage
andreaskurth Nov 11, 2022
2afe45d
[entropy_src/dv] Exclude TL and alert input 0 from toggle coverage
andreaskurth Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions hw/ip/entropy_src/dv/cov/entropy_src_UNR.vRefine
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
SPDX-License-Identifier: Apache-2.0
-->
<refinement-file-root>
<information comment-version="1" creation-time="Thu 13 Oct 2022 08:55:27 PDT" creator="martin.lueker-boden" csCheck="true" save-ref-method="seq" tool-version="Cadence vManager21.03" rules-signature-c="bf7445656414e55d2f2ae9b84886c882">
<information comment-version="1" creation-time="Thu 13 Oct 2022 08:55:27 PDT" creator="martin.lueker-boden" csCheck="true" modified-by="ctopal" modify-time="Fri 11 Nov 2022 11:19:42 GMT" save-ref-method="seq" tool-version="Cadence vManager21.09" rules-signature-c="692c35aaa2695b0d61fde615b73cb2">
<ucm-files>
</ucm-files>
<ccf-files>
Expand All @@ -24,11 +24,12 @@
<rule ccType="inst" ccfFlagsMask="2199136515010-42" domain="icc" entityName="entropy_src/29" entityType="block" excTime="1665673899" file="0" im-checksum="786255092" line="110" name="exclude" reviewer="unknown" text="assign intr_es_fatal_err_o = Stub ? '0 : core_intr_es_fatal_err;" user="1" vscope="default"></rule>
<rule ccType="inst" ccfFlagsMask="2199136515010-42" domain="icc" entityName="entropy_src/32" entityType="block" excTime="1665673903" file="0" im-checksum="786255092" line="111" name="exclude" reviewer="unknown" text="assign alert_test = Stub ? stub_alert_test : core_alert_test;" user="1" vscope="default"></rule>
<rule ccType="inst" ccfFlagsMask="2199136515010-42" domain="icc" entityName="entropy_src/35" entityType="block" excTime="1665673907" file="0" im-checksum="786255092" line="112" name="exclude" reviewer="unknown" text="assign alert = Stub ? stub_alert : core_alert;" user="1" vscope="default"></rule>
<rule ccType="inst" domain="icc" entityName="entropy_src/&quot;tl_o.d_param&quot;/2" entityType="toggle-bit" excTime="1665674018" excludeKind="rise" name="exclude" reviewer="unknown" user="1" vscope="default"></rule>
<rule ccType="inst" domain="icc" entityName="entropy_src/&quot;tl_o.d_param&quot;/1" entityType="toggle-bit" excTime="1665674018" excludeKind="rise" name="exclude" reviewer="unknown" user="1" vscope="default"></rule>
<rule ccType="inst" domain="icc" entityName="entropy_src/&quot;tl_o.d_param&quot;/0" entityType="toggle-bit" excTime="1665674018" excludeKind="rise" name="exclude" reviewer="unknown" user="1" vscope="default"></rule>
<rule ccType="inst" domain="icc" entityName="entropy_src/&quot;tl_o.d_sink&quot;/0" entityType="toggle-bit" excTime="1665674022" excludeKind="rise" name="exclude" reviewer="unknown" user="1" vscope="default"></rule>
<rule ccType="inst" domain="icc" entityName="entropy_src/&quot;entropy_src_xht_o.active&quot;/0" entityType="toggle-bit" excTime="1665674041" excludeKind="fall" name="exclude" reviewer="unknown" user="1" vscope="default"></rule>
<rule ccType="inst" domain="icc" entityName="entropy_src/&quot;tl_i.a_param&quot;" entityType="toggle" excTime="1668165562" name="exclude" reviewer="unknown" user="1" vscope="default"></rule>
<rule ccType="inst" domain="icc" entityName="entropy_src/&quot;tl_i.a_user.rsvd&quot;" entityType="toggle" excTime="1668165562" name="exclude" reviewer="unknown" user="1" vscope="default"></rule>
<rule ccType="inst" domain="icc" entityName="entropy_src/&quot;tl_o.d_param&quot;" entityType="toggle" excTime="1668165562" name="exclude" reviewer="unknown" user="1" vscope="default"></rule>
<rule ccType="inst" domain="icc" entityName="entropy_src/&quot;tl_o.d_sink&quot;" entityType="toggle" excTime="1668165562" name="exclude" reviewer="unknown" user="1" vscope="default"></rule>
<rule ccType="inst" domain="icc" entityName="entropy_src/&quot;alert_rx_i[0].ping_p&quot;" entityType="toggle" excTime="1668165562" name="exclude" reviewer="unknown" user="1" vscope="default"></rule>
<rule ccType="inst" domain="icc" entityName="entropy_src/&quot;alert_rx_i[0].ping_n&quot;" entityType="toggle" excTime="1668165562" name="exclude" reviewer="unknown" user="1" vscope="default"></rule>
Comment on lines +27 to +32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in a comment in the other PR, these should have already been excluded by our common Xcelium coverage exclusion tcl script:
https:/lowRISC/opentitan/blob/master/hw/dv/tools/xcelium/common_cov_excl.tcl#L6

It is worth investigating why it is not taking effect.

<rule ccType="inst" domain="icc" entityName="entropy_src/&quot;tl_o.d_user.rsp_intg&quot;/6" entityType="toggle-bit" excTime="1665674153" excludeKind="rise" name="exclude" reviewer="unknown" user="1" vscope="default"></rule>
<rule ccType="inst" ccfFlagsMask="2199136515010-42" domain="icc" entityName="entropy_src/u_reg/u_chk/u_chk/52/1/2" entityType="min-term" excTime="1665676144" file="2" im-checksum="1463376409" line="68" name="exclude" reviewer="unknown" text="(syndrome_o == 7'h6b) ^ data_i[43]" ung="0" user="1" vscope="default"></rule>
<rule ccType="inst" ccfFlagsMask="2199136515010-42" domain="icc" entityName="entropy_src/u_reg/u_chk/u_chk/52/1/4" entityType="min-term" excTime="1665676144" file="2" im-checksum="1463376409" line="68" name="exclude" reviewer="unknown" text="(syndrome_o == 7'h6b) ^ data_i[43]" ung="0" user="1" vscope="default"></rule>
Expand Down
3 changes: 2 additions & 1 deletion hw/ip/entropy_src/dv/cov/entropy_src_extht_exclusions.vRefine
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
Exclusions for XHT related ports that have not yet been exercised (yet can be waived for V2)
-->
<refinement-file-root>
<information comment-version="1" creation-time="Mon 17 Oct 2022 18:11:34 PDT" creator="martin.lueker-boden" csCheck="true" save-ref-method="seq" tool-version="Cadence vManager21.03" rules-signature-c="5d15c37ee928c5507f402e54ad4cbf3f">
<information comment-version="1" creation-time="Mon 17 Oct 2022 18:11:34 PDT" creator="martin.lueker-boden" csCheck="false" modified-by="ctopal" modify-time="Fri 11 Nov 2022 11:20:33 GMT" save-ref-method="seq" tool-version="Cadence vManager21.09" rules-signature-c="b176e7638a12335e11c62f7491d9193">
<ucm-files>
</ucm-files>
<ccf-files>
Expand All @@ -28,6 +28,7 @@
<rule ccType="inst" domain="icc" entityName="entropy_src/&quot;entropy_src_xht_i.continuous_test&quot;" entityType="toggle" excTime="1666055353" name="exclude" reviewer="unknown" user="3" vscope="default"></rule>
<rule ccType="inst" domain="icc" entityName="entropy_src/&quot;entropy_src_xht_i.test_fail_hi_pulse&quot;" entityType="toggle" excTime="1666055358" name="exclude" reviewer="unknown" user="3" vscope="default"></rule>
<rule ccType="inst" domain="icc" entityName="entropy_src/&quot;entropy_src_xht_i.test_fail_lo_pulse&quot;" entityType="toggle" excTime="1666055364" name="exclude" reviewer="unknown" user="3" vscope="default"></rule>
<rule ccType="inst" domain="icc" entityName="entropy_src/&quot;entropy_src_xht_o.active&quot;" entityType="toggle" excTime="1668165625" name="exclude" reviewer="unknown" user="3" vscope="default"></rule>
<rule ccType="inst" domain="icc" entityName="uvm_pkg/&quot;lockable_field_cov_of_entropy_src_reg_block.extht_hi_thresholds.fips_thresh&quot;" entityType="covergroup" excTime="1667143544" name="exclude" reviewer="unknown" user="0" vscope="default"></rule>
<rule ccType="inst" domain="icc" entityName="uvm_pkg/&quot;lockable_field_cov_of_entropy_src_reg_block.extht_hi_thresholds.bypass_thresh&quot;" entityType="covergroup" excTime="1667143544" name="exclude" reviewer="unknown" user="0" vscope="default"></rule>
<rule ccType="inst" domain="icc" entityName="uvm_pkg/&quot;lockable_field_cov_of_entropy_src_reg_block.extht_lo_thresholds.fips_thresh&quot;" entityType="covergroup" excTime="1667143544" name="exclude" reviewer="unknown" user="0" vscope="default"></rule>
Expand Down