[entropy_src/rtl] Fix observe fifo overflow reg #21640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-filali
requested review from
jadephilipoom,
pamaury,
vogelpi and
jwnrt
and removed request for
a team and
jadephilipoom
h-filali
force-pushed
the
es-fix-observe-fifo-overflow-reg
branch
2 times, most recently
from
f97d1bf
to
5eb275b
Compare
vogelpi
approved these changes
Feb 23, 2024
| swaccess: "rw0c", | ||
| swaccess: "ro", |
There was a problem hiding this comment.
This is not a documentation change :-)
Maybe it doesn't make sense to split up this small PR. It's only +16 lines...
There was a problem hiding this comment.
I squashed the first two commits.
h-filali
force-pushed
the
es-fix-observe-fifo-overflow-reg
branch
from
5eb275b
to
2e34813
Compare
added 3 commits
February 26, 2024 13:07
…sing This commit applies the fw_ov_rd_fifo_overflow signal in case of an overflow. It used to only send a pulse through the register but now the signal is applied until the FIFO has been emptied once and is receiving contiguous data again. This commit also aligns the documentation for the FW_OV_RD_FIFO_OVERFLOW register. The register is now not clearable by software. It instead is cleared by hardware. Signed-off-by: Hakim Filali <[email protected]>
…nism This commit aligns SW with the new way of how the observe fifo overflow works. The overflow is now latched and not only pulsed. Furthermore, the clear doesn't need to be done by software anymore. Signed-off-by: Hakim Filali <[email protected]>
This commit changes the mubi4 true test from strict to loose for the rng_fips register field. This is done to ensure that the entropy_src still requests high quality entropy even if one of the mubi bits is flipped. Signed-off-by: Hakim Filali <[email protected]>
h-filali
force-pushed
the
es-fix-observe-fifo-overflow-reg
branch
from
2e34813
to
f3692d2
Compare
This was referenced Mar 29, 2024
moidx
added a commit
to moidx/caliptra-rtl
that referenced
this pull request
Apr 23, 2024
Keep applying fw_ov_rd_fifo_overflow instead of pulsing. This commit is a manual port of the following Opentitan commit: b454878f2528b49318ff2b604cb8d59a6e59b0ea Which is associated with lowRISC/opentitan#21640. Original commit description: This commit applies the fw_ov_rd_fifo_overflow signal in case of an overflow. It used to only send a pulse through the register but now the signal is applied until the FIFO has been emptied once and is receiving contiguous data again. This commit also aligns the documentation for the FW_OV_RD_FIFO_OVERFLOW register. The register is now not clearable by software. It instead is cleared by hardware. Signed-off-by: Miguel Osorio <[email protected]>
moidx
added a commit
to moidx/caliptra-rtl
that referenced
this pull request
Apr 24, 2024
Keep applying fw_ov_rd_fifo_overflow instead of pulsing. This commit is a manual port of the following Opentitan commit: b454878f2528b49318ff2b604cb8d59a6e59b0ea Which is associated with lowRISC/opentitan#21640. Original commit description: This commit applies the fw_ov_rd_fifo_overflow signal in case of an overflow. It used to only send a pulse through the register but now the signal is applied until the FIFO has been emptied once and is receiving contiguous data again. This commit also aligns the documentation for the FW_OV_RD_FIFO_OVERFLOW register. The register is now not clearable by software. It instead is cleared by hardware. Signed-off-by: Miguel Osorio <[email protected]>
moidx
added a commit
to moidx/caliptra-rtl
that referenced
this pull request
Apr 24, 2024
Keep applying fw_ov_rd_fifo_overflow instead of pulsing. This commit is a manual port of the following Opentitan commit: b454878f2528b49318ff2b604cb8d59a6e59b0ea Which is associated with lowRISC/opentitan#21640. Original commit description: This commit applies the fw_ov_rd_fifo_overflow signal in case of an overflow. It used to only send a pulse through the register but now the signal is applied until the FIFO has been emptied once and is receiving contiguous data again. This commit also aligns the documentation for the FW_OV_RD_FIFO_OVERFLOW register. The register is now not clearable by software. It instead is cleared by hardware. Signed-off-by: Miguel Osorio <[email protected]>
moidx
added a commit
to moidx/caliptra-rtl
that referenced
this pull request
Apr 25, 2024
Keep applying fw_ov_rd_fifo_overflow instead of pulsing. This commit is a manual port of the following Opentitan commit: b454878f2528b49318ff2b604cb8d59a6e59b0ea Which is associated with lowRISC/opentitan#21640. Original commit description: This commit applies the fw_ov_rd_fifo_overflow signal in case of an overflow. It used to only send a pulse through the register but now the signal is applied until the FIFO has been emptied once and is receiving contiguous data again. This commit also aligns the documentation for the FW_OV_RD_FIFO_OVERFLOW register. The register is now not clearable by software. It instead is cleared by hardware. Signed-off-by: Miguel Osorio <[email protected]>
howardtr
pushed a commit
to chipsalliance/caliptra-rtl
that referenced
this pull request
Apr 25, 2024
Keep applying fw_ov_rd_fifo_overflow instead of pulsing. This commit is a manual port of the following Opentitan commit: b454878f2528b49318ff2b604cb8d59a6e59b0ea Which is associated with lowRISC/opentitan#21640. Original commit description: This commit applies the fw_ov_rd_fifo_overflow signal in case of an overflow. It used to only send a pulse through the register but now the signal is applied until the FIFO has been emptied once and is receiving contiguous data again. This commit also aligns the documentation for the FW_OV_RD_FIFO_OVERFLOW register. The register is now not clearable by software. It instead is cleared by hardware. Signed-off-by: Miguel Osorio <[email protected]>
calebofearth
pushed a commit
to chipsalliance/caliptra-rtl
that referenced
this pull request
May 17, 2024
Keep applying fw_ov_rd_fifo_overflow instead of pulsing. This commit is a manual port of the following Opentitan commit: b454878f2528b49318ff2b604cb8d59a6e59b0ea Which is associated with lowRISC/opentitan#21640. Original commit description: This commit applies the fw_ov_rd_fifo_overflow signal in case of an overflow. It used to only send a pulse through the register but now the signal is applied until the FIFO has been emptied once and is receiving contiguous data again. This commit also aligns the documentation for the FW_OV_RD_FIFO_OVERFLOW register. The register is now not clearable by software. It instead is cleared by hardware. Signed-off-by: Miguel Osorio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR latches the observe FIFO overflow register signal instead of only pulsing it.
For a more detailed explanation have a look at the individual commit messages.
This PR also contains a commit that changes a mubi4 test true signal from strict to loose.
This is done as a follow up for #21369.
Closes #21279