Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sival] Backport entropy_src_fw_override_test to earlgrey_es_sival #21810

Merged
merged 3 commits into from
Mar 4, 2024
Merged

[sival] Backport entropy_src_fw_override_test to earlgrey_es_sival #21810

merged 3 commits into from
Mar 4, 2024

Conversation

jwnrt
Copy link
Contributor

@jwnrt jwnrt commented Mar 4, 2024 •
edited
Loading

There are two changes from the version on master required due to RTL differences:

  1. entropy_testutils_drain_observe_fifo must manually clear the FIFO overflow flag.
  2. The test "payload" does not run OTBN because it requires the FIPS bit to be set which isn't possible from software. Instead, 3 repeats of the AES and KMAC payloads are run.

Original #21562

@jwnrt jwnrt requested a review from a team as a code owner March 4, 2024 11:14
vogelpi
vogelpi approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@vogelpi vogelpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vogelpi
Copy link
Contributor

vogelpi commented Mar 4, 2024

Out of interest, have you ever counted how many seeds/interrupts the entropy_src generates per test run?

@jwnrt
[sw] Rename dif for writing to entropy_src FIFO
8c61723 
This DIF is actually writing bytes to the FIFO the feeds into the
preconditioner when in firmware override mode, not to the observe FIFO.

Signed-off-by: James Wainwright <[email protected]>
(cherry picked from commit 9d098dd)
@jwnrt
[sw] Move some entropy_src code to testutils
9c9325d 
Signed-off-by: James Wainwright <[email protected]>
(cherry picked from commit 7f914a3)
@jwnrt
[sival] Add extract and insert entropy_src test
b66e51c 
Signed-off-by: James Wainwright <[email protected]>
(cherry picked from commit 9f56456)
@jwnrt jwnrt force-pushed the earlgrey-es-sival-entropy-src-fw-override branch from 529a1a4 to b66e51c Compare March 4, 2024 13:04
@jwnrt
Copy link
Contributor Author

jwnrt commented Mar 4, 2024 •
edited
Loading

I haven't collected those stats, but the test does write 19488 words total to the FW override FIFO for the master branch version (so that's 10 x the AES, KMAC, and OTBN payloads). Is that helpful? It's the same number of words on every run.

@vogelpi
Copy link
Contributor

vogelpi commented Mar 4, 2024

Thanks, I think that should be fine. Just wanted to get an idea for the amount of entropy that's actually requested by the consumers.

@jwnrt jwnrt merged commit c0f837a into lowRISC:earlgrey_es_sival Mar 4, 2024
29 checks passed
@jwnrt jwnrt deleted the earlgrey-es-sival-entropy-src-fw-override branch March 4, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamaury pamaury pamaury approved these changes

@vogelpi vogelpi vogelpi approved these changes

@h-filali h-filali Awaiting requested review from h-filali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwnrt @vogelpi @pamaury