Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow deployment when mongodb/redis.auth.existingSecret is not specified #1096

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

jamesandariese
Copy link
Contributor

Proposed changes

Without specifying an existingSecret for mongodb and redis, the following errors occur:

Error: INSTALLATION FAILED: template: lowcoder/templates/api-service/configMap.yaml:5:23: executing "lowcoder/templates/api-service/configMap.yaml" at <index $redisSecret.data .Values.redis.auth.existingSecretPasswordKey>: error calling index: index of untyped nil

and

Error: INSTALLATION FAILED: template: lowcoder/templates/api-service/secrets.yaml:6:29: executing "lowcoder/templates/api-service/secrets.yaml" at <index $mongoSecret.data "password">: error calling index: index of untyped nil

This creates a default at the data level as well for when there is no secret at all so that we aren't trying to find index "password" in nil (which is an error) instead of an empty dict (which allows the default "" to function because the index-on-nil error doesn't halt execution).

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for lowcoder-cloud ready!

Name Link
🔨 Latest commit 700d860
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-cloud/deploys/66ba2ebb42d65e0008edbaa5
😎 Deploy Preview https://deploy-preview-1096--lowcoder-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ludomikula ludomikula changed the base branch from main to dev August 12, 2024 15:46
Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for lowcoder-test canceled.

Name Link
🔨 Latest commit 700d860
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/66ba2ebbb696fb00080b5032

@ludomikula
Copy link
Collaborator

Thank you for the contribution!

@ludomikula ludomikula merged commit dfaf965 into lowcoder-org:dev Aug 12, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants