Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deploy to Elestio button updated #1118

Merged
merged 12 commits into from
Aug 23, 2024

Conversation

kaiwalyakoparkar
Copy link
Contributor

Proposed changes

Hey there, we recently revamped our one-click "Deploy to Elestio" button, this pull request is regarding updating it in the Readme file.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Copy link

netlify bot commented Aug 19, 2024

👷 Deploy request for lowcoder-cloud pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit aed8a57

Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-08-21 at 17 06 04

Is there any chance, that you could deliver a button in the standard format?

@kaiwalyakoparkar
Copy link
Contributor Author

Screenshot 2024-08-21 at 17 06 04 Is there any chance, that you could deliver a button in the standard format?

Hey, Sure! does this look fine?
image

FalkWolsky
FalkWolsky previously approved these changes Aug 23, 2024
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super good! Thank you very much

@FalkWolsky FalkWolsky changed the base branch from main to dev August 23, 2024 10:39
@FalkWolsky FalkWolsky dismissed their stale review August 23, 2024 10:39

The base branch was changed.

@FalkWolsky FalkWolsky merged commit a28726f into lowcoder-org:dev Aug 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 'Deploy to Elestio' button to newer version
3 participants