Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Theme style fixes relative to active/inactive preventOverwriteStyles flag #1217

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

raheeliftikhar5
Copy link
Collaborator

@raheeliftikhar5 raheeliftikhar5 commented Oct 2, 2024

Proposed changes

With this adaption, we improve the Themes Styles handling and here especially the attribute "prevent overwriting of local styles set in Apps by theme".

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for lowcoder-test ready!

Name Link
🔨 Latest commit 9481da0
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/66fece872cb6e60008f71ea8
😎 Deploy Preview https://deploy-preview-1217--lowcoder-test.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@FalkWolsky FalkWolsky merged commit 1cd0379 into dev Oct 3, 2024
6 of 7 checks passed
@FalkWolsky FalkWolsky deleted the theme-style-fixes branch October 3, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants