Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supporting aliyun oss data source #744

Merged
merged 9 commits into from
Sep 27, 2024

Conversation

encorearon
Copy link
Contributor

@encorearon encorearon commented Mar 6, 2024

Proposed changes

Add a data source plugin that supports Alibaba Cloud OSS (Object Storage Service) .

Allow some operations on stored object through the form of accessing OSS resources via STS (Security Token Service).

  • List
  • Put

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

Copy link

netlify bot commented Mar 6, 2024

👷 Deploy request for lowcoder-cloud pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 584827e

@encorearon encorearon changed the title Feature/aliyun oss supporting aliyun oss data source Mar 6, 2024
@FalkWolsky FalkWolsky changed the base branch from main to dev March 6, 2024 09:41
FalkWolsky
FalkWolsky previously approved these changes Mar 6, 2024
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a wonderful contribution! Thank you very much.
We can only hope you may find time to enable the delete of files too as you mentioned in the code already...

@encorearon
Copy link
Contributor Author

What a wonderful contribution! Thank you very much. We can only hope you may find time to enable the delete of files too as you mentioned in the code already...

Thank you very much for your recognition and encouragement! I will implement this feature and update the code as soon as possible.

Copy link

netlify bot commented Mar 6, 2024

👷 Deploy request for lowcoder-test pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 1b05a0e

@FalkWolsky
Copy link
Contributor

We have trouble with the Checks. The Build of the Node Service fails.
Let u look into it soon.

@FalkWolsky
Copy link
Contributor

Did you find time to look into the reasons, why Node Build fails?
The error message is ➤ YN0028: │ The lockfile would have been modified by this install, which is explicitly forbidden.

@encorearon
Copy link
Contributor Author

it seems that I should commit the yarn.lock file

@FalkWolsky FalkWolsky merged commit d44694b into lowcoder-org:dev Sep 27, 2024
2 of 3 checks passed
@FalkWolsky
Copy link
Contributor

We merged it now and fixed small things.
Generally, if you add something tp package.json, you would need to run yarn install before the commit. This helps to keep the package-lock.json in sync and avoid build errors.

However! Thank you very much for this great contribution! We are sure, many community members will find great value in it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants