Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system proxy settings in REST and GRAPHQL plugins #939

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

ludomikula
Copy link
Collaborator

Proposed changes

Adds possibility to use system proxy if configured for REST and GraphQL plugins.
Introduces usage of proxy username/password.

System environment properties recognized:

  • http.proxyHost
  • http.proxyPort
  • http.proxyUsername
  • http.proxyPassword

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

n/a

Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for lowcoder-test ready!

Name Link
🔨 Latest commit 121d377
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/6660b5ced3404300084be608
😎 Deploy Preview https://deploy-preview-939--lowcoder-test.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A truly helpful contribution!! Thank you very much. This will help to increase network security and flexibility a lot!

@FalkWolsky FalkWolsky merged commit c599b75 into dev Jun 5, 2024
6 checks passed
@FalkWolsky FalkWolsky deleted the fix_rest_system_proxy branch June 5, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants