Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kanban draggable bug #968

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Fix kanban draggable bug #968

merged 5 commits into from
Jun 19, 2024

Conversation

freddysundowner
Copy link
Collaborator

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for lowcoder-cloud canceled.

Name Link
🔨 Latest commit 1c93c74
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-cloud/deploys/66729b33100aed0008d54737

Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a sensitive place (event handling), so we will follow it carefully.
Nevertheless, thank you very much for the change - so we can make the Kanban working

@FalkWolsky FalkWolsky merged commit 5a8f5ba into main Jun 19, 2024
7 checks passed
@FalkWolsky FalkWolsky deleted the fix-kanban-draggable-bug branch June 19, 2024 08:48
@FalkWolsky FalkWolsky restored the fix-kanban-draggable-bug branch June 19, 2024 08:55
@FalkWolsky FalkWolsky deleted the fix-kanban-draggable-bug branch June 19, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants