Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qlog the packet_type as part of the packet header, not the event itself #2758

Merged
merged 1 commit into from
Dec 6, 2020

Conversation

marten-seemann
Copy link
Member

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #2758 (4f55731) into master (5a0ce24) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2758      +/-   ##
==========================================
- Coverage   86.24%   86.23%   -0.01%     
==========================================
  Files         133      133              
  Lines        9143     9138       -5     
==========================================
- Hits         7885     7880       -5     
  Misses        910      910              
  Partials      348      348              
Impacted Files Coverage Δ
qlog/event.go 97.60% <ø> (-0.06%) ⬇️
qlog/packet_header.go 94.87% <100.00%> (+0.13%) ⬆️
qlog/qlog.go 95.63% <100.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0ce24...4f55731. Read the comment docs.

@marten-seemann marten-seemann merged commit b623a10 into master Dec 6, 2020
@marten-seemann marten-seemann deleted the qlog-packet-type branch December 6, 2020 04:23
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants