Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix interpretation of time.Time{} as a pacing deadline #2980

Merged
merged 1 commit into from
Jan 16, 2021

Conversation

marten-seemann
Copy link
Member

Fixes #2974. Closes #2977 (that PR just fixes the symptoms, not the underlying problem).

The pacer returns the zero value of time.Time when a packet can be sent immediately. The session uses the zero value to unset the pacing deadline.

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #2980 (33d058f) into master (4653549) will increase coverage by 0.76%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2980      +/-   ##
==========================================
+ Coverage   86.12%   86.88%   +0.76%     
==========================================
  Files         135      135              
  Lines        9379    10029     +650     
==========================================
+ Hits         8077     8713     +636     
- Misses        943      947       +4     
- Partials      359      369      +10     
Impacted Files Coverage Δ
internal/congestion/pacer.go 100.00% <ø> (ø)
session.go 82.25% <100.00%> (+4.39%) ⬆️
zero_rtt_queue.go 92.31% <0.00%> (-1.81%) ⬇️
internal/ackhandler/received_packet_handler.go 75.00% <0.00%> (-1.12%) ⬇️
qlog/event.go 98.26% <0.00%> (+0.51%) ⬆️
qlog/qlog.go 95.59% <0.00%> (+0.97%) ⬆️
qlog/packet_header.go 96.92% <0.00%> (+1.27%) ⬆️
internal/wire/transport_parameters.go 91.02% <0.00%> (+2.40%) ⬆️
logging/multiplex.go 100.00% <0.00%> (+2.56%) ⬆️
server.go 86.35% <0.00%> (+4.00%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4653549...33d058f. Read the comment docs.

session.go Outdated Show resolved Hide resolved
The pacer returns the zero value of time.Time when a packet can be sent
immediately. The session uses the zero value to unset the pacing
deadline.
@marten-seemann marten-seemann force-pushed the fix-pacing-deadline-interpretation branch from 592cba4 to 33d058f Compare January 16, 2021 05:35
@marten-seemann marten-seemann merged commit 4bdccca into master Jan 16, 2021
@marten-seemann marten-seemann deleted the fix-pacing-deadline-interpretation branch January 16, 2021 06:09
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky HTTP/0.9 tests
2 participants