Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore ProtocolLib 4.x series support #100

Merged
merged 4 commits into from
Jan 20, 2023
Merged

Restore ProtocolLib 4.x series support #100

merged 4 commits into from
Jan 20, 2023

Conversation

GatitoUwU
Copy link
Contributor

Fix for 1.8.8 when using ProtocolLib 4.8.0 :D

> [14:02:59 ERROR]: [BungeeGuard] Unhandled exception occured in onPacketReceiving(PacketEvent) for BungeeGuard
java.lang.NoClassDefFoundError: com/comphenix/protocol/injector/temporary/TemporaryPlayerFactory
at me.lucko.bungeeguard.spigot.listener.ProtocolHandshakeListener.closeConnection(ProtocolHandshakeListener.java:134) ~[BungeeGuard.jar:?]
at me.lucko.bungeeguard.spigot.listener.ProtocolHandshakeListener.access$300(ProtocolHandshakeListener.java:55) ~[BungeeGuard.jar:?]
at me.lucko.bungeeguard.spigot.listener.ProtocolHandshakeListener$Adapter.onPacketReceiving(ProtocolHandshakeListener.java:104) ~[BungeeGuard.jar:?]
at com.comphenix.protocol.injector.SortedPacketListenerList.invokeReceivingListener(SortedPacketListenerList.java:114) [ProtocolLib-4.5.1.jar:4.5.1]
at com.comphenix.protocol.injector.SortedPacketListenerList.invokePacketRecieving(SortedPacketListenerList.java:67) [ProtocolLib-4.5.1.jar:4.5.1]
at com.comphenix.protocol.injector.PacketFilterManager.handlePacket(PacketFilterManager.java:590) [ProtocolLib-4.5.1.jar:4.5.1]
at com.comphenix.protocol.injector.PacketFilterManager.invokePacketRecieving(PacketFilterManager.java:557) [ProtocolLib-4.5.1.jar:4.5.1]
at com.comphenix.protocol.injector.netty.ProtocolInjector.packetReceived(ProtocolInjector.java:350) [ProtocolLib-4.5.1.jar:4.5.1]
at com.comphenix.protocol.injector.netty.ProtocolInjector.onPacketReceiving(ProtocolInjector.java:315) [ProtocolLib-4.5.1.jar:4.5.1]
at com.comphenix.protocol.injector.netty.ChannelInjector.decode(ChannelInjector.java:538) [ProtocolLib-4.5.1.jar:4.5.1]
at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:249) [server.jar:1_8_R3]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:149) [server.jar:1_8_R3]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) [server.jar:1_8_R3]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:319) [server.jar:1_8_R3]
at com.comphenix.protocol.injector.netty.ChannelInjector$2.channelRead(ChannelInjector.java:259) [ProtocolLib-4.5.1.jar:4.5.1]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) [server.jar:1_8_R3]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:319) [server.jar:1_8_R3]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:163) [server.jar:1_8_R3]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) [server.jar:1_8_R3]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:319) [server.jar:1_8_R3]
at net.minecraft.server.v1_8_R3.LegacyPingHandler.channelRead(LegacyPingHandler.java:88) [server.jar:1_8_R3]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) [server.jar:1_8_R3]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:319) [server.jar:1_8_R3]
at io.netty.handler.timeout.ReadTimeoutHandler.channelRead(ReadTimeoutHandler.java:150) [server.jar:1_8_R3]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) [server.jar:1_8_R3]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:319) [server.jar:1_8_R3]
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:787) [server.jar:1_8_R3]
at io.netty.channel.epoll.EpollSocketChannel$EpollSocketUnsafe.epollInReady(EpollSocketChannel.java:722) [server.jar:1_8_R3]
at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:326) [server.jar:1_8_R3]
at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:264) [server.jar:1_8_R3]
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:116) [server.jar:1_8_R3]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_312]
Caused by: java.lang.ClassNotFoundException: com.comphenix.protocol.injector.temporary.TemporaryPlayerFactory
at java.net.URLClassLoader.findClass(URLClassLoader.java:387) ~[?:1.8.0_312]
at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:105) ~[server.jar:1_8_R3]
at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:90) ~[server.jar:1_8_R3]
at java.lang.ClassLoader.loadClass(ClassLoader.java:418) ~[?:1.8.0_312]
at java.lang.ClassLoader.loadClass(ClassLoader.java:351) ~[?:1.8.0_312]
... 32 more
> [14:02:59 ERROR]: Parameters:
net.minecraft.server.v1_8_R3.PacketHandshakingInSetProtocol@222025b7[
a=47
hostname=no, thank u
port=25565
d=LOGIN```

@GatitoUwU GatitoUwU changed the title Restore Protocol 4.x series support Restore ProtocolLib 4.x series support Jan 20, 2023
stijnb1234
stijnb1234 approved these changes Jan 20, 2023
View reviewed changes
Copy link

@stijnb1234 stijnb1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small point of discussion.

...ard-spigot/src/main/java/me/lucko/bungeeguard/spigot/listener/ProtocolHandshakeListener.java Outdated
Comment on lines 71 to 77
try {
Class.forName("com.comphenix.protocol.injector.temporary.MinimalInjector");
plugin.getLogger().info("Using newer ProtocolLib support.");
} catch (ClassNotFoundException e) {
plugin.getLogger().info("Using legacy ProtocolLib support.");
isLegacyProtocolLib = true;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe replace newer/legacy by v4 and v5?

@stijnb1234
Copy link

Closes #88, #92, #96

@lucko lucko merged commit a3c06a7 into lucko:master Jan 20, 2023
@lucko
Copy link
Owner

lucko commented Jan 20, 2023

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stijnb1234 stijnb1234 stijnb1234 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GatitoUwU @stijnb1234 @lucko