Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PDF-XChange Editor #2747

Merged
merged 2 commits into from
Sep 2, 2019
Merged

Add PDF-XChange Editor #2747

merged 2 commits into from
Sep 2, 2019

Conversation

Velgus
Copy link
Contributor

@Velgus Velgus commented Aug 25, 2019

No description provided.

Ash258
Ash258 reviewed Aug 25, 2019
View reviewed changes
Copy link
Contributor

@Ash258 Ash258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is portable edition and there is no persist? This is suspicious.

@Ash258
Copy link
Contributor

Ash258 commented Aug 25, 2019

Is this persist working with simple New-Item? Lots of applications cannot work when custom dat files are not generated by application (or defined without additional headers, format, encoding, ...)

@Velgus
Copy link
Contributor Author

Velgus commented Aug 25, 2019

Seems to work fine. The files' data populates as usual after the first launch and close, and setting changes work fine when re-opened.

@r15ch13 r15ch13 merged commit fe6b234 into ScoopInstaller:master Sep 2, 2019
@Velgus Velgus deleted the pdf-xchange-editor branch September 13, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ash258 Ash258 Ash258 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Velgus @Ash258 @r15ch13