Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rewrote the
Descendants
extension methods to eliminate recursion. The order of returned elements is kept the same.This comes with a significant memory allocation reduction when using
Descendants
over the entire AST like I do in my project.Benchmarking between the recursive and iterative approaches I get this:
Iterative:
Recursive:
Where
Markdig
is only parsing to the AST whileMarkdig_Descendants
parses to AST and loops over descendants once.I have tested that the order is not modified when calling descending anywhere in the test suite.
I don't have tests for
Descendants<T>
ofContainerInline
andContainerBlock
as they appear to not be used anywhere in Markdig itself, but I have included iterative implementations for those as well.In the future, a few bytes could be shaved off by using ValueTuple instead of two stacks.