Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ Simplify TaperedEvaluationTermByRank #757

Merged
merged 2 commits into from
May 20, 2024

Conversation

eduherminio
Copy link
Member

@eduherminio eduherminio commented May 20, 2024

  • Remove duplicated backing field
  • Make inner list an array

Getter properties need to remain for automatic configuration binding purposes.

This is a code simplification that might imply a speed up in practice

[-5, 0], 8+0.08

Score of Lynx-simplify-taperedevaluationtermbyrank-2996-win-x64 vs Lynx 2980 - main: 1383 - 1294 - 1771  [0.510] 4448
...      Lynx-simplify-taperedevaluationtermbyrank-2996-win-x64 playing White: 976 - 369 - 879  [0.636] 2224
...      Lynx-simplify-taperedevaluationtermbyrank-2996-win-x64 playing Black: 407 - 925 - 892  [0.384] 2224
...      White vs Black: 1901 - 776 - 1771  [0.626] 4448
Elo difference: 7.0 +/- 7.9, LOS: 95.7 %, DrawRatio: 39.8 %
SPRT: llr 2.89 (100.1%), lbound -2.25, ubound 2.89 - H1 was accepted

Getter properties need to remain for automatic configuration binding purposes
@eduherminio eduherminio marked this pull request as ready for review May 20, 2024 15:36
@eduherminio eduherminio merged commit 4387070 into main May 20, 2024
27 checks passed
@eduherminio eduherminio deleted the simplify-TaperedEvaluationTermByRank branch May 20, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant