Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Revert "🐛 Detect threefold repetition on pvNode (#796)" #818

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

eduherminio
Copy link
Member

@eduherminio eduherminio commented Jun 16, 2024

This reverts commit 49b926f.

This is an attempt to fix Lynx 1.5.0 inability to convert some completely won endgames, allowing threefold repetitions instead.
Concrete examples:

No adjudication/draws:

Test  | revert-threefold-pvnode
Elo   | 23.54 +- 10.96 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=32MB
LLR   | 2.91 (-2.25, 2.89) [0.00, 5.00]
Games | 2188: +692 -544 =952
Penta | [42, 232, 428, 320, 72]
https://openbench.lynx-chess.com/test/406/

with adjudication/draws

Score of Lynx-revert-threefold-pvnode-3179-win-x64 vs Lynx 3164 - main: 5574 - 5287 - 6256  [0.508] 17117
...      Lynx-revert-threefold-pvnode-3179-win-x64 playing White: 3853 - 1590 - 3116  [0.632] 8559
...      Lynx-revert-threefold-pvnode-3179-win-x64 playing Black: 1721 - 3697 - 3140  [0.385] 8558
...      White vs Black: 7550 - 3311 - 6256  [0.624] 17117
Elo difference: 5.8 +/- 4.1, LOS: 99.7 %, DrawRatio: 36.5 %
SPRT: llr 2.9 (100.3%), lbound -2.25, ubound 2.89 - H1 was accepted

40+0.4, 256MB, no adj/draws

Score of Lynx-revert-threefold-pvnode-3179-win-x64 vs Lynx 3164 - main: 1553 - 1352 - 2583  [0.518] 5488
...      Lynx-revert-threefold-pvnode-3179-win-x64 playing White: 1180 - 338 - 1227  [0.653] 2745
...      Lynx-revert-threefold-pvnode-3179-win-x64 playing Black: 373 - 1014 - 1356  [0.383] 2743
...      White vs Black: 2194 - 711 - 2583  [0.635] 5488
Elo difference: 12.7 +/- 6.7, LOS: 100.0 %, DrawRatio: 47.1 %
SPRT: llr 2.9 (100.2%), lbound -2.25, ubound 2.89 - H1 was accepted

40+0.4, 32MB, no adj/draws

Score of Lynx-revert-threefold-pvnode-3179-win-x64 vs Lynx 3164 - main: 1061 - 864 - 1620  [0.528] 3545
...      Lynx-revert-threefold-pvnode-3179-win-x64 playing White: 816 - 200 - 756  [0.674] 1772
...      Lynx-revert-threefold-pvnode-3179-win-x64 playing Black: 245 - 664 - 864  [0.382] 1773
...      White vs Black: 1480 - 445 - 1620  [0.646] 3545
Elo difference: 19.3 +/- 8.4, LOS: 100.0 %, DrawRatio: 45.7 %
SPRT: llr 2.9 (100.3%), lbound -2.25, ubound 2.89 - H1 was accepted

@eduherminio eduherminio changed the title Revert "🐛 Detect threefold repetition on pvNode (#796)" 🐛 Revert "🐛 Detect threefold repetition on pvNode (#796)" Jun 16, 2024
@eduherminio eduherminio marked this pull request as ready for review June 17, 2024 15:58
@eduherminio eduherminio enabled auto-merge (squash) June 20, 2024 01:35
@eduherminio eduherminio merged commit f79faa3 into main Jun 20, 2024
27 checks passed
@eduherminio eduherminio deleted the revert-threefold-pvnode branch June 20, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant