Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚖ Pawn scaling: don't allow scores to change sign #829

Merged
merged 8 commits into from
Jun 26, 2024

Conversation

eduherminio
Copy link
Member

@eduherminio eduherminio commented Jun 25, 2024

Includes similar fix as #828, and also prevents a winning score to transform into a losing one, and viceversa

Test  | bugfix/eg-pawn-scaling-no-sign-change
Elo   | -0.68 +- 2.80 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=32MB
LLR   | -2.26 (-2.25, 2.89) [0.00, 3.00]
Games | 36748: +11429 -11501 =13818
Penta | [1299, 3990, 7771, 4112, 1202]
https://openbench.lynx-chess.com/test/424/

but

> python .\sprt.py -w 11429 -d 13818 -l 11501 -e0 -5 -e1 0
ELO: -0.681 +- 2.8 [-3.48, 2.12]
LLR: 3.07 [-5.0, 0.0] (-2.94, 2.94)
H1 Accepted

@eduherminio eduherminio changed the title Pawn scaling: don't allow scores to change sign ⚖ Pawn scaling: don't allow scores to change sign Jun 25, 2024
@eduherminio eduherminio marked this pull request as ready for review June 26, 2024 23:39
@eduherminio eduherminio enabled auto-merge (squash) June 26, 2024 23:40
@eduherminio eduherminio merged commit ae32c6e into main Jun 26, 2024
27 checks passed
@eduherminio eduherminio deleted the bugfix/eg-pawn-scaling-no-sign-change branch June 26, 2024 23:44
eduherminio added a commit that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant