Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unnecessary use of fmt.Sprintf #159

Merged
merged 1 commit into from
Jun 6, 2024
Merged

chore: unnecessary use of fmt.Sprintf #159

merged 1 commit into from
Jun 6, 2024

Conversation

testwill
Copy link
Contributor

No description provided.

@GreyXor GreyXor merged commit 1a90868 into m13253:master Jun 6, 2024
1 check passed
@GreyXor
Copy link
Collaborator

GreyXor commented Jun 6, 2024

Thanks @testwill :)

@m13253
Copy link
Owner

m13253 commented Jun 6, 2024

Thanks for the contribution!

I appreciate it!

@vinnyperella
Copy link

That string exists elsewhere in that file is that the only place it needs removed? For example:

return &DNSRequest{
errcode: 400,
errtext: fmt.Sprintf("Invalid argument value: "dns" = %q", requestBase64),

@m13253
Copy link
Owner

m13253 commented Jun 11, 2024

I think the occurrence with %q you pointed out is how Sprintf is supposed to be used.

That’s good as is in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants