Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change default batch creation error logic #145

Merged
merged 1 commit into from
May 20, 2022

Conversation

mchuangatmp
Copy link
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https:/mParticle/mparticle-workflows/blob/stable/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https:/mParticle/mparticle-workflows/blob/stable/.github/workflows/pr-branch-check-name.yml

Summary

  • change default batch creation error logic

Testing Plan

  • batch tests should pass

Master Issue

Copy link
Contributor

@willpassidomo willpassidomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, test update makes sense

@mchuangatmp mchuangatmp merged commit d0cf645 into development May 20, 2022
@mchuangatmp mchuangatmp deleted the fix/SQDSDKS-4076 branch May 20, 2022 18:52
github-actions bot pushed a commit that referenced this pull request May 20, 2022
### [5.40.2](v5.40.1...v5.40.2) (2022-05-20)

### Bug Fixes

* change default batch creation error logic ([#145](#145)) ([d0cf645](d0cf645))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.40.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants