Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change incrementUserAttribute method signature to accept Number #188

Merged
merged 4 commits into from
Jul 21, 2022
Merged

fix: change incrementUserAttribute method signature to accept Number #188

merged 4 commits into from
Jul 21, 2022

Conversation

jshin-tse
Copy link
Contributor

… in line with iOS implementation

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https:/mParticle/mparticle-workflows/blob/stable/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https:/mParticle/mparticle-workflows/blob/stable/.github/workflows/pr-branch-check-name.yml

Summary

Testing Plan

  • Implicit type conversions should do most of the work, though maybe an overloaded incrementUserAttribute that uses int can be kept for legacy customers that rely on the data type of a user attribute being int?

Master Issue

@mchuangatmp mchuangatmp force-pushed the fix/increment_user_attr_arg_type_change branch from 86a9233 to a2f3aeb Compare June 22, 2022 17:38
@willpassidomo
Copy link
Contributor

Hey @jshin-tse, it looks like you still have a few compilation errors. Let me know if you want to walk through this one with me :)

@willpassidomo willpassidomo force-pushed the fix/increment_user_attr_arg_type_change branch 5 times, most recently from 71135b9 to 3935ffd Compare July 18, 2022 23:04
@willpassidomo willpassidomo force-pushed the fix/increment_user_attr_arg_type_change branch 5 times, most recently from b17ae3d to 7577de8 Compare July 20, 2022 14:39
@willpassidomo willpassidomo force-pushed the fix/increment_user_attr_arg_type_change branch from 7577de8 to c5e2dd6 Compare July 20, 2022 18:31
@willpassidomo willpassidomo force-pushed the fix/increment_user_attr_arg_type_change branch 4 times, most recently from 9e2e88a to baed378 Compare July 21, 2022 15:38
@willpassidomo willpassidomo force-pushed the fix/increment_user_attr_arg_type_change branch from baed378 to 04a51f9 Compare July 21, 2022 18:18
@willpassidomo willpassidomo changed the title fix: change incrementUserAttribute method signature to accept doubles… fix: change incrementUserAttribute method signature to accept Number Jul 21, 2022
@willpassidomo willpassidomo merged commit 0c8229f into mParticle:development Jul 21, 2022
willpassidomo pushed a commit that referenced this pull request Jul 21, 2022
@jshin-tse @willpassidomo
feat: update MParticleUser.incrementUserAttribute to accept Number (#188
670bdd6 
)

* feat: change incrementUserAttribute method signature to accept Number

* feat: add TypedUserAttributeListener for the async MParticleUser.getUserAttributes() method to fetch non-String attribute values
github-actions bot pushed a commit that referenced this pull request Jul 21, 2022
@mparticle-automation
chore(release): 5.43.0
fe71aa2 
## [5.43.0](v5.42.0...v5.43.0) (2022-07-21)

### Features

* update MParticleUser.incrementUserAttribute to accept Number ([#188](#188)) ([670bdd6](670bdd6))
@willpassidomo willpassidomo mentioned this pull request Jul 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchuangatmp mchuangatmp mchuangatmp approved these changes

@willpassidomo willpassidomo Awaiting requested review from willpassidomo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jshin-tse @willpassidomo @mchuangatmp