Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update sonarcloud check to new format #209

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

mchuangatmp
Copy link
Contributor

@mchuangatmp mchuangatmp commented Jul 25, 2022

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https:/mParticle/mparticle-workflows/blob/stable/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https:/mParticle/mparticle-workflows/blob/stable/.github/workflows/pr-branch-check-name.yml

Summary

  • update sonarcloud check to new format

Testing Plan

  • make sure sonarcloud works for forked PRs

Master Issue

Copy link
Contributor

@willpassidomo willpassidomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@mchuangatmp mchuangatmp merged commit 821d61e into development Jul 25, 2022
@mchuangatmp mchuangatmp deleted the feat/SQDSDKS-4347-testing branch July 25, 2022 18:20
github-actions bot pushed a commit that referenced this pull request Aug 1, 2022
## [5.44.0](v5.43.0...v5.44.0) (2022-08-01)

### Features

* update sonarcloud check to new format ([#209](#209)) ([821d61e](821d61e))

### Bug Fixes

* reset logic, fixing orchestrator ([#213](#213)) ([f9379e9](f9379e9))

### Updates & Maintenance

* Update Submodules ([11893b6](11893b6))
* update visibility for crossplatform testing ([#211](#211)) ([b03f210](b03f210))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.44.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Aug 1, 2022
## [5.44.0](v5.43.0...v5.44.0) (2022-08-01)

### Features

* update sonarcloud check to new format ([#209](#209)) ([821d61e](821d61e))

### Bug Fixes

* reset logic, fixing orchestrator ([#213](#213)) ([f9379e9](f9379e9))

### Updates & Maintenance

* Update Submodules ([7c9be34](7c9be34))
* update visibility for crossplatform testing ([#211](#211)) ([b03f210](b03f210))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.44.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants