fix: Kit integration forwarding unplanned/blocked events when fired early on app run #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdozor
requested changes
Jun 27, 2023
| @@ -77,12 +77,13 @@ public void loadKitLibrary() { | |||
| .onKitsLoaded(() -> { | |||
| mKitManager = kitManager; | |||
| setKitsLoaded(true); | |||
| updateDataplan(mCoreCallbacks.getDataplanOptions()); | |||
There was a problem hiding this comment.
this reads like a race condition - we need to ensure that the data plan is set before kits are loaded. specifically - we need to make sure that no user attribute, events, etc can be sent to kits prior to the data plan.
in my view ideally we'd load the data plan in the same function updateKits above that loads kit configuration. the idea of KitConfiguration is that it should contain absolutely everything needed, and we only start kits after it's been completely parsed.
samdozor
approved these changes
Jun 28, 2023
mparticle-automation
added a commit
that referenced
this pull request
Jun 28, 2023
## [5.51.3](v5.51.2...v5.51.3) (2023-06-28) ### Bug Fixes * Fixing initialization & de-initialization issue on kits. ([#393](#393)) ([d02b5b3](d02b5b3)) * Kit integration forwarding unplanned/blocked events when fired early on app run ([#394](#394)) ([b99a1c6](b99a1c6)) ### Updates & Maintenance * Update submodules ([1ba89e3](1ba89e3))
|
🎉 This PR is included in version 5.51.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kit integration forwarding unplanned/blocked events when fired early on app run
Instructions
developmentSummary
Testing Plan
@mmustafa-tse was able to verify the fix.
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)