Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SQDSDKS-5543 formatting, clean-up and reorganizing imports #406

Merged
merged 5 commits into from
Jul 25, 2023
Merged

feat: SQDSDKS-5543 formatting, clean-up and reorganizing imports #406

merged 5 commits into from
Jul 25, 2023

Conversation

markvdouw
Copy link
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https:/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https:/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Reformatting code, cleanup and organize imports

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@markvdouw markvdouw assigned einsteinx2 and unassigned einsteinx2 Jul 24, 2023
BrandonStalnaker
BrandonStalnaker approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through all the whole PR and only saw code changes to unused imports and code comments so it LGTM

@markvdouw markvdouw merged commit 341118c into development Jul 25, 2023
20 of 23 checks passed
@markvdouw markvdouw deleted the feat/SQDSDKS-5543_formatting branch July 25, 2023 14:52
mparticle-automation added a commit that referenced this pull request Aug 1, 2023
@mparticle-automation
chore: 5.53.0 (release)
e9a7220 
## [5.53.0](v5.52.1...v5.53.0) (2023-08-01)

### Features

* SQDSDKS-5543 formatting, clean-up and reorganizing imports ([#406](#406)) ([341118c](341118c))

### Updates & Maintenance

* Update submodules ([13594c5](13594c5))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.53.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonStalnaker BrandonStalnaker BrandonStalnaker approved these changes

@einsteinx2 einsteinx2 Awaiting requested review from einsteinx2

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markvdouw @mparticle-automation @BrandonStalnaker @einsteinx2